refactor: remove IpfsOptions::{new,default}

rationale for `new`: IpfsOptions is already a struct with only pub
fields, explaining them again in a doc comment would be useless.

rationale for `default`: config file loading is quite out of place being
*inside* the library. configuration is an applciation level concern.

this also removes UninitializedIpfs::default and replaces their uses
with IpfsOptions::inmemory_with_generated_keys or direct struct
creation.

Author: Joonas Koivunen

src/lib.rs

@@ -208,79 +208,6 @@ impl<I: Borrow<Keypair>> DebuggableKeypair<I> {
     }
 }
 
-impl IpfsOptions {
-    pub fn new(
-        ipfs_path: PathBuf,
-        keypair: Keypair,
-        bootstrap: Vec<(Multiaddr, PeerId)>,
-        mdns: bool,
-        kad_protocol: Option<String>,
-        listening_addrs: Vec<Multiaddr>,
-        span: Option<Span>,
-    ) -> Self {
-        Self {
-            ipfs_path,
-            keypair,
-            bootstrap,
-            mdns,
-            kad_protocol,
-            listening_addrs,
-            span,
-        }
-    }
-}
-
-impl Default for IpfsOptions {
-    /// Create `IpfsOptions` from environment.
-    ///
-    /// # Panics
-    ///
-    /// Can panic if two threads call this method at the same time due to race condition on
-    /// creating a configuration file under `IPFS_PATH` and other thread failing to read the just
-    /// created empty file. Because of this, the implementation has been disabled in tests.
-    fn default() -> Self {
-        use self::config::ConfigFile;
-
-        if cfg!(test) {
-            // making this implementation conditional on `not(test)` results in multiple dead_code
-            // lints on config.rs but for rustc 1.42.0 at least having this `cfg!(test)` branch
-            // does not result in the same.
-            panic!(
-                "This implementation must not be invoked when testing as it cannot be safely
-                used from multiple threads"
-            );
-        }
-
-        let ipfs_path = if let Ok(path) = env::var("IPFS_PATH") {
-            PathBuf::from(path)
-        } else {
-            let root = if let Some(home) = dirs::home_dir() {
-                home
-            } else {
-                env::current_dir().unwrap()
-            };
-            root.join(".rust-ipfs")
-        };
-        let config_path = dirs::config_dir()
-            .unwrap()
-            .join("rust-ipfs")
-            .join("config.json");
-        let config = ConfigFile::new(config_path).unwrap();
-        let keypair = config.identity_key_pair();
-        let bootstrap = config.bootstrap();
-
-        IpfsOptions {
-            ipfs_path,
-            keypair,
-            bootstrap,
-            mdns: true,
-            kad_protocol: None,
-            listening_addrs: Vec::new(),
-            span: None,
-        }
-    }
-}
-
 /// The facade for the Ipfs node.
 ///
 /// The facade has most of the functionality either directly as a method or the functionality can
@@ -395,10 +322,6 @@ impl<Types: IpfsTypes> UninitializedIpfs<Types> {
         }
     }
 
-    pub fn default() -> Self {
-        Self::new(IpfsOptions::default())
-    }
-
     /// Initialize the ipfs node. The returned `Ipfs` value is cloneable, send and sync, and the
     /// future should be spawned on a executor as soon as possible.
     pub async fn start(self) -> Result<(Ipfs<Types>, impl Future<Output = ()>), Error> {
@@ -1822,10 +1745,4 @@ mod tests {
         ipfs.remove_pin(&cid, false).await.unwrap();
         assert!(!ipfs.is_pinned(&cid).await.unwrap());
     }
-
-    #[test]
-    #[should_panic]
-    fn default_ipfs_options_disabled_when_testing() {
-        IpfsOptions::default();
-    }
 }