chore(unixfs): clippies

this includes a change on making `unixfs::InvalidCidInLink` properly
`#[non_exhaustive]` instead of using the hidden field trick. it probably
isn't a breaking change, but then again requires a more recent rustc,
which sort of makes it a breaking change.

Author: koivunej

unixfs/CHANGELOG.md

@@ -1,8 +1,10 @@
 # Next
 
 * Document panic introduced in walker ergonomics [#435]
+* `#[non_exhaustive]` on `unixfs::InvalidCidInLink` error [#480]
 
 [#435]: https://github.com/rs-ipfs/rust-ipfs/pull/435
+[#480]: https://github.com/rs-ipfs/rust-ipfs/pull/480
 
 # 0.2.0
 

unixfs/src/dir/builder/custom_pb.rs

@@ -15,7 +15,10 @@ impl<'a> CustomFlatUnixFs<'a> {
     fn mapped(&self) -> impl Iterator<Item = NamedLeafAsPBLink<'_>> + '_ {
         self.links
             .iter()
-            .map(|triple| triple.as_ref().map(|l| NamedLeafAsPBLink(l)).unwrap())
+            // FIXME: this unwrap here seems dangerious; it seems to follow from
+            // `crate::dir::builder::iter::Leaves` assumption that all of these options have
+            // already been filled at the previous stages of post-order visit
+            .map(|triple| triple.as_ref().map(NamedLeafAsPBLink).unwrap())
     }
 }
 

unixfs/src/lib.rs

@@ -37,6 +37,7 @@ pub(crate) mod test_support;
 
 /// A link could not be transformed into a Cid.
 #[derive(Debug)]
+#[non_exhaustive]
 pub struct InvalidCidInLink {
     /// The index of this link, from zero
     pub nth: usize,
@@ -47,8 +48,6 @@ pub struct InvalidCidInLink {
     pub name: Cow<'static, str>,
     /// Error from the attempted conversion
     pub source: cid::Error,
-    /// This is to deny creating these outside of the crate
-    hidden: (),
 }
 
 impl<'a> From<(usize, pb::PBLink<'a>, cid::Error)> for InvalidCidInLink {
@@ -70,7 +69,6 @@ impl<'a> From<(usize, pb::PBLink<'a>, cid::Error)> for InvalidCidInLink {
             hash,
             name,
             source,
-            hidden: (),
         }
     }
 }