From 5e048338a9e82bdf3ae5981e36516c8928e71b24 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Mon, 9 Jun 2025 20:26:41 +0100 Subject: [PATCH 1/4] fix: do not throw on empty cdata --- packages/rrweb-snapshot/src/rebuild.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/rrweb-snapshot/src/rebuild.ts b/packages/rrweb-snapshot/src/rebuild.ts index 692da2d281..0b8f74c127 100644 --- a/packages/rrweb-snapshot/src/rebuild.ts +++ b/packages/rrweb-snapshot/src/rebuild.ts @@ -432,6 +432,9 @@ function buildNode( } return doc.createTextNode(n.textContent); case NodeType.CDATA: + if (n.textContent.trim() === '') { + return null; + } return doc.createCDATASection(n.textContent); case NodeType.Comment: return doc.createComment(n.textContent); From 415f73d30d02b6ecf4ed7223197f2e21e1d6532d Mon Sep 17 00:00:00 2001 From: pauldambra Date: Tue, 1 Jul 2025 14:51:47 +0100 Subject: [PATCH 2/4] fix: move a console log to the warn method so it can be suppressed --- packages/rrweb/src/replay/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/rrweb/src/replay/index.ts b/packages/rrweb/src/replay/index.ts index 5f1101cc23..81abc994b1 100644 --- a/packages/rrweb/src/replay/index.ts +++ b/packages/rrweb/src/replay/index.ts @@ -263,7 +263,7 @@ export class Replayer { this.virtualDom.mirror, ); } catch (e) { - console.warn(e); + this.warn(e); } this.virtualDom.destroyTree(); From 9ee667f943a484286daab1ef181960e258f049e6 Mon Sep 17 00:00:00 2001 From: Paul D'Ambra Date: Tue, 1 Jul 2025 14:52:36 +0100 Subject: [PATCH 3/4] Discard changes to packages/rrweb-snapshot/src/rebuild.ts --- packages/rrweb-snapshot/src/rebuild.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/rrweb-snapshot/src/rebuild.ts b/packages/rrweb-snapshot/src/rebuild.ts index 0b8f74c127..692da2d281 100644 --- a/packages/rrweb-snapshot/src/rebuild.ts +++ b/packages/rrweb-snapshot/src/rebuild.ts @@ -432,9 +432,6 @@ function buildNode( } return doc.createTextNode(n.textContent); case NodeType.CDATA: - if (n.textContent.trim() === '') { - return null; - } return doc.createCDATASection(n.textContent); case NodeType.Comment: return doc.createComment(n.textContent); From b604a760d56c14dc41dc6aad6a49cf116f20e649 Mon Sep 17 00:00:00 2001 From: pauldambra Date: Tue, 1 Jul 2025 15:27:57 +0100 Subject: [PATCH 4/4] changeset --- .changeset/tiny-singers-pump.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/tiny-singers-pump.md diff --git a/.changeset/tiny-singers-pump.md b/.changeset/tiny-singers-pump.md new file mode 100644 index 0000000000..f51f3ce6ca --- /dev/null +++ b/.changeset/tiny-singers-pump.md @@ -0,0 +1,6 @@ +--- +"rrweb-snapshot": patch +"rrweb": patch +--- + +Use the provided logger from player config instead of directly calling console.warn"