Skip to content

Commit 720e174

Browse files
committed
Simplify the parentId check, doesn't need to ever by null
1 parent b5b04e2 commit 720e174

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/rrweb/src/record/mutation.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ export default class MutationBuffer {
190190

191191
let n: Node | null = null;
192192
let parentNode: Node | null = null;
193-
let parentId: number | null = null;
193+
let parentId: number = -1;
194194
let nextSibling: Node | null = null;
195195
let ancestorBad = false;
196196
const missingParents = new Set<Node>();
@@ -266,7 +266,7 @@ export default class MutationBuffer {
266266

267267
this.addedSet.delete(n); // don't re-iterate
268268

269-
if (!parentNode || parentId === -1 || parentId === null) {
269+
if (!parentNode || parentId === -1) {
270270
missingParents.add(n); // ensure any added child nodes can also early-out
271271
continue;
272272
} else if (ancestorBad) {

0 commit comments

Comments
 (0)