Is there a way to use an external hono server?

[rtrampox]

Where the entire react-router app becomes a hono instance, that you can import and route via another hono app.

[rphlmr]

It is created inside createHonoServer but you can pass your own!
https://github.com/rphlmr/react-router-hono-server/blob/main/examples/node/custom-mount/app/server/index.ts

[rphlmr]

Okay, I will take another look at my example (https://github.com/rphlmr/react-router-hono-server/tree/1f8fc7201879f03389b6853a4f8ef77e36cef31d/examples/node/custom-app-dir) in case something has been broken since the last release.

[rtrampox]

Can this, and the #72 issue be related to the same root problem?

[rtrampox]

Okay, I will take another look at my example (https://github.com/rphlmr/react-router-hono-server/tree/1f8fc7201879f03389b6853a4f8ef77e36cef31d/examples/node/custom-app-dir) in case something has been broken since the last release.

While searching through the code, it seems that these couple regexes are the issue:

react-router-hono-server/src/dev.ts

Lines 250 to 267 in 1f8fc72

	// Create and apply the Hono dev server plugin
	devServerPlugin = honoDevServer({
	adapter,
	injectClientScript: false,
	entry: pluginConfig.serverEntryPoint,
	export: options.dev?.export || "default",
	exclude: [
	new RegExp(
	`^(?=\\/${pluginConfig.appDirectory.replace(/^\/+|\/+$/g, "").replaceAll("/", "\\/")}\\/)((?!.*\\.data(\\?|$)).*\\..*(\\?.*)?$)`
	),
	/\?import(\?.*)?$/,
	/^\/@.+$/,
	/^\/node_modules\/.*/,
	`/${pluginConfig.appDirectory}/**/.*/**`,
	...(pluginConfig.dev?.exclude || []),
	],
	});

after making it a simpler regex, some requests were able to pass:

// Create and apply the Hono dev server plugin
devServerPlugin = honoDevServer({
  adapter,
  injectClientScript: false,
  entry: pluginConfig.serverEntryPoint,
  export: options.dev?.export || "default",
  exclude: [
    /^\/@.+$/,
    /^\/node_modules\/.*/,
    /\?import(?:&.*)?$/,
    /\.css(?:$|\?)/,
    /\.js(?:$|\?)/,
    ...(pluginConfig.dev?.exclude || []),
  ],
});

[rphlmr]

It's possible that I don't handle correctly a appDirectory with / :/

[rtrampox]

I think that I was able to fix it. The issue here is that this part of the code is not handling backslashes, and the pluginConfig.appDirectory seems to be returning a backslash, where "src/app" would be "src\app". I don't know if this can be happening only on Windows but is pretty much possible.

react-router-hono-server/src/dev.ts

Lines 257 to 259 in 1f8fc72

	new RegExp(
	`^(?=\\/${pluginConfig.appDirectory.replace(/^\/+|\/+$/g, "").replaceAll("/", "\\/")}\\/)((?!.*\\.data(\\?|$)).*\\..*(\\?.*)?$)`
	),

a fix would be making both of the regexes that are using the appDirectory also handle backslashes:

devServerPlugin = honoDevServer({
  adapter,
  injectClientScript: false,
  entry: pluginConfig.serverEntryPoint,
  export: options.dev?.export || "default",
  exclude: [
    new RegExp(
      `^/${pluginConfig.appDirectory.replace(/^[/\\]+|[/\\]+$/g, "").replace(/[/\\]+/g, "/")}\/(?!.*\\.data(\\?|$)).*\\..*(\\?.*)?$`
    ),
    /\?import(\?.*)?$/,
    /^\/@.+$/,
    /^\/node_modules\/.*/,
    new RegExp(
      `^/${pluginConfig.appDirectory.replace(/^[/\\]+|[/\\]+$/g, "").replace(/[/\\]+/g, "/")}\/.*\/\\..*\/.*`
    ),
    ...(pluginConfig.dev?.exclude || []),
  ],
});