Set filter on dimension via context menu

[IvoMoor]

A shortcut to set a filter on a dimension value via the context menu:

This should set a filter (include) for the dimension and value that was selected. Either direct, or via opening the filter panel, whatever is easiest.

[rpbouman]

If there is no such filter item already, this is easy - we just add the filter item

If a filter item already exists, we need to be careful to do the right thing.

• at any rate, the current filter somehow does not exclude the value that the user wants to add a filter for.

• it could be that the current filter is of type in,like or between and its value list contains the value;

• or it could be that the filter is of type not in, not between, or not like and its value list either does not contain this value, or contains it but it is disabled.

  • if the user chooses "include" then this should probably mean to keep only this value. We will implement this by changing the filter type to in, clearing the list of values, and adding only the current value.

  • if the user chooses "exclude" then this probably means the filter should be adjusted to exclude also this value

    • if the existing filter is of type in, then it must mean the chosen value is already part of the list (else the user could not have selected it). In this case, the value should be removed from the list. (Alternatively the value could be kept on the list, but be disabled. We could decide this either through config or through prompting the user. We will keep this idea in mind for the future.)
    • if the existing filter is of type not in
      • if the current value is not in the list, then it should be added to the list of excluded values
      • if the current value is already in the list, then it must mean it is disabled, and then we should enable it (so it gets excluded from the result)
    • if the existing filter is of type not like
      This is somewhat (but not quite) like the "not in" case (above)
      • if none of the current patterns match the current value, we can simply add the current value as a new pattern
      • if there is a pattern that is exactly equal to the current value, and it is disabled, then we can enable it.
      • if there is a (disabled) pattern that matches the current value, then we cannot simply enable it as that would likely also exclude other values. So instead we should then just add the current value as new pattern.
    • if the existing filter is of type like, and the list of values that satisfies the like contains more values than only the current value, then we have a problem, as we cannot modify this filter in a way that would exclude only the current value. In this case, we should probably prompt the user, either to inform them that their request can't be executed or to ask offer them alternative actions (we can park this for a future improvement and for now just refuse to satisfy the request)
    • if the existing filter is of type between, then we can identify the ranges that includes the current value, and split them so they won't include the current value anymore.
    • if the existing filter is of type not between, then we can simply add an entry from and to the current value

[rpbouman]

This has been implemented for a while now. @IvoMoor can you verify and either

• amend the issue if something is still left to be desired
• close the issue if it's okay