Simplify settings php-backed session expiry

pabzm · pabzm · commit b804142ab6e8 · 2025-10-22T16:43:39.000+02:00
The previous use of __MTIME doesn't actually make sense at all.
diff --git a/program/lib/Roundcube/session/php.php b/program/lib/Roundcube/session/php.php
@@ -97,10 +97,6 @@ public function start()
 
         $this->key = session_id();
         $this->ip = $_SESSION['__IP'] ?? null;
-        if (is_int($_SESSION['__MTIME'])) {
-            $this->expires_at = $_SESSION['__MTIME'] + $this->lifetime;
-        } else {
-            $this->expires_at = null;
-        }
+        $this->expires_at = time() + $this->lifetime;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -97,10 +97,6 @@ public function start()`
`97`	`97`
`98`	`98`	`$this->key = session_id();`
`99`	`99`	`$this->ip = $_SESSION['__IP'] ?? null;`
`100`		`- if (is_int($_SESSION['__MTIME'])) {`
`101`		`- $this->expires_at = $_SESSION['__MTIME'] + $this->lifetime;`
`102`		`- } else {`
`103`		`- $this->expires_at = null;`
`104`		`- }`
	`100`	`+ $this->expires_at = time() + $this->lifetime;`
`105`	`101`	`}`
`106`	`102`	`}`