Fix getting IMAP vendor name (#9654)

pabzm · web-flow · commit 6a7e96c212e2 · 2024-09-29T11:18:32.000+02:00
In some cases, the array's keys where upper case, and the previous code
produced a warning and resulted in an empty string, even though the
name was present.
diff --git a/program/lib/Roundcube/rcube_imap.php b/program/lib/Roundcube/rcube_imap.php
@@ -655,7 +655,7 @@ public function get_vendor()
             $ident = null;
         }
 
-        $vendor = (string) (!empty($ident) ? $ident['name'] : '');
+        $vendor = (string) ($ident['name'] ?? $ident['NAME'] ?? '');
         $ident = strtolower($vendor . ' ' . $this->conn->data['GREETING']);
         $vendors = ['cyrus', 'dovecot', 'uw-imap', 'gimap', 'hmail', 'greenmail'];
 

Original file line number	Diff line number	Diff line change
`@@ -655,7 +655,7 @@ public function get_vendor()`
`655`	`655`	`$ident = null;`
`656`	`656`	`}`
`657`	`657`
`658`		`- $vendor = (string) (!empty($ident) ? $ident['name'] : '');`
	`658`	`+ $vendor = (string) ($ident['name'] ?? $ident['NAME'] ?? '');`
`659`	`659`	`$ident = strtolower($vendor . ' ' . $this->conn->data['GREETING']);`
`660`	`660`	`$vendors = ['cyrus', 'dovecot', 'uw-imap', 'gimap', 'hmail', 'greenmail'];`
`661`	`661`