Skip to content

Commit fc749ab

Browse files
committed
Recover previous changes
Signed-off-by: Sakshay Mahna <sakshum19@gmail.com>
1 parent 20f5096 commit fc749ab

File tree

3 files changed

+8
-0
lines changed

3 files changed

+8
-0
lines changed

nav2_graceful_controller/include/nav2_graceful_controller/parameter_handler.hpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ struct Parameters
3434
double transform_tolerance;
3535
double min_lookahead;
3636
double max_lookahead;
37+
bool interpolate_after_goal;
3738
double max_robot_pose_search_dist;
3839
double k_phi;
3940
double k_delta;

nav2_graceful_controller/src/parameter_handler.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ ParameterHandler::ParameterHandler(
4141
node, plugin_name_ + ".min_lookahead", rclcpp::ParameterValue(0.25));
4242
declare_parameter_if_not_declared(
4343
node, plugin_name_ + ".max_lookahead", rclcpp::ParameterValue(1.0));
44+
declare_parameter_if_not_declared(
45+
node, plugin_name_ + ".interpolate_after_goal", rclcpp::ParameterValue(false));
4446
declare_parameter_if_not_declared(
4547
node, plugin_name_ + ".max_robot_pose_search_dist",
4648
rclcpp::ParameterValue(costmap_size_x / 2.0));
@@ -76,6 +78,7 @@ ParameterHandler::ParameterHandler(
7678
node->get_parameter(plugin_name_ + ".transform_tolerance", params_.transform_tolerance);
7779
node->get_parameter(plugin_name_ + ".min_lookahead", params_.min_lookahead);
7880
node->get_parameter(plugin_name_ + ".max_lookahead", params_.max_lookahead);
81+
node->get_parameter(plugin_name_ + ".interpolate_after_goal", params_.interpolate_after_goal);
7982
node->get_parameter(
8083
plugin_name_ + ".max_robot_pose_search_dist", params_.max_robot_pose_search_dist);
8184
if (params_.max_robot_pose_search_dist < 0.0) {
@@ -186,6 +189,8 @@ ParameterHandler::dynamicParametersCallback(std::vector<rclcpp::Parameter> param
186189
params_.initial_rotation = parameter.as_bool();
187190
} else if (param_name == plugin_name_ + ".prefer_final_rotation") {
188191
params_.prefer_final_rotation = parameter.as_bool();
192+
} else if (param_name == plugin_name_ + ".interpolate_after_goal") {
193+
params_.interpolate_after_goal = parameter.as_bool();
189194
} else if (param_name == plugin_name_ + ".allow_backward") {
190195
if (params_.initial_rotation && parameter.as_bool()) {
191196
RCLCPP_WARN(

nav2_graceful_controller/test/test_graceful_controller.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ TEST(GracefulControllerTest, dynamicParameters) {
270270
{rclcpp::Parameter("test.transform_tolerance", 1.0),
271271
rclcpp::Parameter("test.min_lookahead", 1.0),
272272
rclcpp::Parameter("test.max_lookahead", 2.0),
273+
rclcpp::Parameter("test.interpolate_after_goal", false),
273274
rclcpp::Parameter("test.k_phi", 4.0),
274275
rclcpp::Parameter("test.k_delta", 5.0),
275276
rclcpp::Parameter("test.beta", 6.0),
@@ -294,6 +295,7 @@ TEST(GracefulControllerTest, dynamicParameters) {
294295
EXPECT_EQ(node->get_parameter("test.transform_tolerance").as_double(), 1.0);
295296
EXPECT_EQ(node->get_parameter("test.min_lookahead").as_double(), 1.0);
296297
EXPECT_EQ(node->get_parameter("test.max_lookahead").as_double(), 2.0);
298+
EXPECT_EQ(node->get_parameter("test.interpolate_after_goal").as_bool(), false);
297299
EXPECT_EQ(node->get_parameter("test.k_phi").as_double(), 4.0);
298300
EXPECT_EQ(node->get_parameter("test.k_delta").as_double(), 5.0);
299301
EXPECT_EQ(node->get_parameter("test.beta").as_double(), 6.0);

0 commit comments

Comments
 (0)