Fix dynamic callback for footprint clearing enable (#4885)

georgflick · web-flow · commit 447c8cec3b52 · 2025-01-30T10:03:46.000-08:00
the else condition is a duplication of the one before and was so never
executed.

Signed-off-by: Georg Flick &lt;georg.flick@enway.ai&gt;
diff --git a/nav2_costmap_2d/plugins/static_layer.cpp b/nav2_costmap_2d/plugins/static_layer.cpp
@@ -496,9 +496,7 @@ StaticLayer::dynamicParametersCallback(
         height_ = size_y_;
         has_updated_data_ = true;
         current_ = false;
-      }
-    } else if (param_type == ParameterType::PARAMETER_BOOL) {
-      if (param_name == name_ + "." + "footprint_clearing_enabled") {
+      } else if (param_name == name_ + "." + "footprint_clearing_enabled") {
         footprint_clearing_enabled_ = parameter.as_bool();
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -496,9 +496,7 @@ StaticLayer::dynamicParametersCallback(`
`496`	`496`	`height_ = size_y_;`
`497`	`497`	`has_updated_data_ = true;`
`498`	`498`	`current_ = false;`
`499`		`- }`
`500`		`- } else if (param_type == ParameterType::PARAMETER_BOOL) {`
`501`		`- if (param_name == name_ + "." + "footprint_clearing_enabled") {`
	`499`	`+ } else if (param_name == name_ + "." + "footprint_clearing_enabled") {`
`502`	`500`	`footprint_clearing_enabled_ = parameter.as_bool();`
`503`	`501`	`}`
`504`	`502`	`}`