Fix dynamic callback for footprint clearing enable (#4885) (#4886)

mergify[bot] · georgflick · web-flow · commit 359c74425d40 · 2025-01-30T11:18:35.000-08:00
the else condition is a duplication of the one before and was so never executed. Signed-off-by: Georg Flick <georg.flick@enway.ai> (cherry picked from commit 447c8ce) Co-authored-by: Georg Flick <54032815+georgflick@users.noreply.github.com>
diff --git a/nav2_costmap_2d/plugins/static_layer.cpp b/nav2_costmap_2d/plugins/static_layer.cpp
@@ -502,9 +502,7 @@ StaticLayer::dynamicParametersCallback(
         height_ = size_y_;
         has_updated_data_ = true;
         current_ = false;
-      }
-    } else if (param_type == ParameterType::PARAMETER_BOOL) {
-      if (param_name == name_ + "." + "footprint_clearing_enabled") {
+      } else if (param_name == name_ + "." + "footprint_clearing_enabled") {
         footprint_clearing_enabled_ = parameter.as_bool();
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -502,9 +502,7 @@ StaticLayer::dynamicParametersCallback(`
`502`	`502`	`height_ = size_y_;`
`503`	`503`	`has_updated_data_ = true;`
`504`	`504`	`current_ = false;`
`505`		`- }`
`506`		`- } else if (param_type == ParameterType::PARAMETER_BOOL) {`
`507`		`- if (param_name == name_ + "." + "footprint_clearing_enabled") {`
	`505`	`+ } else if (param_name == name_ + "." + "footprint_clearing_enabled") {`
`508`	`506`	`footprint_clearing_enabled_ = parameter.as_bool();`
`509`	`507`	`}`
`510`	`508`	`}`