Rebuild/update Docker images?

[gavanderhoorn]

On pkgs/container/reach_ros2 it looks like the last update to the images was about a year ago.

@marip8: could we push an update? Would save creating custom ones.

Related: where is the Dockerfile ? :)

---

Edit: are those just for CI btw? When trying to start the ghcr.io/ros-industrial/reach_ros2:humble-master the image, I get:

/bin/bash: /home/runner/work/_actions/ros-industrial/industrial_ci/master/industrial_ci/src/run.sh: No such file or directory

[marip8]

Related: where is the Dockerfile ? :)

The docker images in the container registry were generated by industrial_ci back when we were using that package for CI (instead of colcon-action). So there currently is no Dockerfile, but I can add one relatively easily and add a CI job to rebuild it at some frequency.

Edit: are those just for CI btw?

You can still use the existing images to run reach studies by overriding the entrypoint of the image. Getting GUI applications to work is a bit complicated without docker compose, but I can add that to the repository as well. I imagine you probably can't easily build any applications off these existing Docker images though because they have the old ROS2 GPG key.

[gavanderhoorn]

So there currently is no Dockerfile, but I can add one relatively easily and add a CI job to rebuild it at some frequency.

might be nice, saves users from having to do that themselves.

You can still use the existing images to run reach studies by overriding the entrypoint of the image.

of course, but the fewer barriers there are, probably the better.

Perhaps a similar approach to what is/was done for the SnP repository/ies would work here?

[nikhil-sethi]

The paths are empty. /home/runner/work/_actions/ros-industrial/industrial_ci/master/industrial_ci does not have the run.sh script and /home/runner/work/reach_ros2/reach_ros2 doesn't have any source or install files.

@marip8 I can create a PR based on this Dockerfile

[marip8]

Sounds good. I would suggest consolidating the two RUN commands in that Dockerfile into a single command that uses both a tmpfs and bind mount, like we did with thetesseract Docker image recently, to minimize the number of source code artifacts that persist in the Docker image.

FWIW, the build artifacts are installed to /root/ros-industrial/reach_ros2_target_ws/install. The /home/runner/work directories are temporary mount points for the old CI process.

[nikhil-sethi]

Thanks for clearing that up @marip8. I've created PR #44 with the nice tmpfs tip.