Skip to content

Commit 5ee7171

Browse files
committed
fix some links and add GoC and data contributor #156
1 parent 6b6b211 commit 5ee7171

File tree

4 files changed

+25
-6
lines changed

4 files changed

+25
-6
lines changed

DESCRIPTION

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ Authors@R: c(person("Sam", "Albers", email = "sam.albers@gov.bc.ca", role = c("a
77
person("Dewey", "Dunnington", email = "dewey@fishandwhistle.net", role = "ctb"),
88
person("Ryan", "Whaley", email = "rdgwhaley@gmail.com", role = "ctb"),
99
person("Province of British Columbia", role = "cph"),
10+
person("Government of Canada", role = "dtc"),
1011
person("Luke", "Winslow", role = "rev",
1112
comment = "Reviewed for rOpenSci"),
1213
person("Laura", "DeCicco", role = "rev",
@@ -16,8 +17,8 @@ Description: Provides functions to access historical and real-time national 'hyd
1617
data from Water Survey of Canada data sources (<https://dd.weather.gc.ca/hydrometric/csv/> and
1718
<https://collaboration.cmc.ec.gc.ca/cmc/hydrometrics/www/>) and then applies tidy data principles.
1819
License: Apache License (== 2.0) | file LICENSE
19-
URL: https://docs.ropensci.org/tidyhydat, https://github.com/ropensci/tidyhydat
20-
BugReports: https://github.com/ropensci/tidyhydat/issues
20+
URL: https://docs.ropensci.org/tidyhydat/, https://github.com/ropensci/tidyhydat/
21+
BugReports: https://github.com/ropensci/tidyhydat/issues/
2122
Depends:
2223
R (>= 3.2.3)
2324
Imports:

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
- When add a local timezone column, use the most common timezone in the data rather than the first one. This just seems more likely to be useful to users
33
- Add more documentation to `realtime_add_local_datetime` to make how timezones are dealt with clearer (#157)
44
- Expose the query time for realtime functions as an attribute (#160)
5+
- Add Government of Canada as data contributor (#156)
56

67
# tidyhydat 0.5.3
78
- Allow pkg to loaded without internet and rather just issue an message when it is not. (#149)

cran-comments.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,20 @@
1-
tidyhydat 0.5.4
1+
tidyhydat 0.5.4
2+
=========================
3+
- When add a local timezone column, use the most common timezone in the data rather than the first one. This just seems more likely to be useful to users
4+
- Add more documentation to `realtime_add_local_datetime` to make how timezones are dealt with clearer (#157)
5+
- Expose the query time for realtime functions as an attribute (#160)
6+
7+
## Test environments
8+
* win-builder (via `devtools::check_win_devel()` and `devtools::check_win_release()`)
9+
* local Windows 10, R 4.1.0 (via R CMD check --as-cran)
10+
* ubuntu-20.04, r: 'release' (github actions)
11+
* ubuntu-20.04, r: 'devel' (github actions)
12+
* macOS, r: 'release' (github actions)
13+
* windows, r: 'release' (github actions)
14+
* Fedora Linux, R-devel, clang, gfortran - r-hub
15+
* Debian Linux, R-release, GCC (debian-gcc-release) - r-hub
16+
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit - r-hub
17+
218

319
tidyhydat 0.5.3
420
=========================

man/tidyhydat-package.Rd

Lines changed: 4 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)