Skip to content

Commit 356d776

Browse files
committed
comments
1 parent 2413253 commit 356d776

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cran-comments.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
## Resubmission
22

3-
This is a resubmission.
3+
This is a resubmission. I addressed the following comments:
44

55
> Please write references in the description of the DESCRIPTION file in the form
66
> authors (year) <doi:...>
@@ -23,7 +23,7 @@ I have added the link <https://huggingface.co/> to the description
2323
> You have examples wrapped in if(FALSE). Please never do that. Ideally find toy examples that can be regularly executed and checked. Lengthy examples (> 5 sec), can be wrapped in \donttest{}. \dontrun{} can be used if the example really cannot be executed (e.g. because of missing additional software, missing API keys, ...) by the user.
2424
2525
**Answer**:
26-
There was one example that trigger the installation of python packages wrapped in `if(FALSE)`. This has been changed to `\dontrun{}`. But notice that very few examples can be actually run, since most functions depend on additional software (python packages).
26+
There was one example that triggered the installation of python packages wrapped in an `if(FALSE)`. This has been changed to `\dontrun{}`. But notice that very few examples can be actually run in CRAN, since almost all functions depend on additional software (python packages).
2727

2828

2929
> You write information messages to the console that cannot be easily suppressed.

0 commit comments

Comments
 (0)