Skip to content

Commit 753f120

Browse files
committed
Fix for significant warning from 'R CMD check'
Signed-off-by: Stefan Widgren <stefan.widgren@gmail.com>
1 parent 4c5e3fc commit 753f120

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/libgit2/src/refs.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,13 @@ int git_reference_lookup_resolved(
232232
nesting--)
233233
{
234234
if (nesting != max_nesting) {
235-
strncpy(scan_name, ref->target.symbolic, sizeof(scan_name));
235+
/* Fix in git2r to handle a significant
236+
warning from 'R CMD check'
237+
libgit2/src/refs.c:235:4: warning:
238+
‘strncpy’ specified bound 1024 equals
239+
destination size [-Wstringop-truncation] */
240+
strncpy(scan_name, ref->target.symbolic, sizeof(scan_name) - 1);
241+
/* strncpy(scan_name, ref->target.symbolic, sizeof(scan_name)); */
236242
git_reference_free(ref);
237243
}
238244

0 commit comments

Comments
 (0)