Skip to content

Commit 3caeaec

Browse files
committed
fix copilot review
1 parent d3094a0 commit 3caeaec

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

.github/instructions/copilot-agent.instructions.md.new

Whitespace-only changes.

.github/instructions/flutter.instructions.md.new

Whitespace-only changes.

modules/common/lib/analytics/abstract/analytics_client.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
/// Additional method to track custom events with a specific type.
24
/// Follow the naming convention for event types.
35
/// Future trackInitLoginFlow() => trackEvent('init_login', properties: {...});
@@ -9,7 +11,7 @@ abstract class AnalyticsClient {
911
/// Example usage:
1012
/// trackFunction(() => loginWithEmailPassword(email, password), 'login_triggered', properties: {email: email});
1113
Future trackFunction(
12-
Function fn,
14+
FutureOr<void> Function() fn,
1315
String name, {
1416
Map<String, dynamic>? properties,
1517
});

modules/common/lib/analytics/concrete/firebase_analytics.dart

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
import 'package:common/analytics/abstract/analytics_client.dart';
24

35
class FirebaseAnalytics implements AnalyticsClient {
@@ -51,8 +53,9 @@ class FirebaseAnalytics implements AnalyticsClient {
5153

5254
@override
5355
Future trackFunction(
54-
Function fn,
56+
FutureOr<void> Function() fn,
5557
String name, {
5658
Map<String, dynamic>? properties,
57-
}) => fn().then((_) => trackEvent(name, properties: properties));
59+
}) =>
60+
Future.value(fn()).then((_) => trackEvent(name, properties: properties));
5861
}

0 commit comments

Comments
 (0)