ansible-core 2.19 breaks trellis

[LucasDemea]

Version

ansible-core >= 2.19

What did you expect to happen?

playbooks run without crashing

What actually happens?

ansible-core >= 2.19 introduces many bugs related to formats such as:

• Conditionals must have a boolean result.
• The following variables must be formatted as dicts: '[]'

These are related to breaking changes in ansible-core 2.19 : see https://docs.ansible.com/ansible/latest/porting_guides/porting_guide_core_2.19.html

Steps to reproduce

install the latest ansible by running, in trellis folder :

rm -rf .trellis/virtualenv && trellis init

Then run a playbook : vagrant provision

System info

No response

Log output

Please confirm this isn't a support request.

Yes

[LucasDemea]

A workaround until roles are fixed is to add ansible-core<2.19.0 to requirements.txt

[retlehs]

I'm not seeing any errors when provisioning with 2.19, can you provide any output with the errors?

One thing to note is that I'm not using Vagrant and have 100% moved to Lima VM's for everything, which is more performant and a lot better than Vagrant

[LucasDemea]

❯ trellis provision --tags=common production

//.....

TASK [common : Fail if there are duplicate site keys within host's wordpress_sites] ***
[ERROR]: The `loop` value must resolve to a 'list', not 'str'.
Origin: /***/trellis/roles/common/tasks/main.yml:18:11

16           {{ item.site_keys | to_nice_yaml | indent(2) }}
17     when: item.site_keys | count
18     loop: "{{ site_keys_by_env_pair }}"
             ^ column 11

Provide a list of items/templates, or a template resolving to a list.

fatal: [51.83.98.22]: FAILED! => {"msg": "The `loop` value must resolve to a 'list', not 'str'."}

[LucasDemea]

One thing to note is that I'm not using Vagrant and have 100% moved to Lima VM's for everything, which is more performant and a lot better than Vagrant

I'd like to as well, because vagrant is really slow, but Lima is for MacOS users only, and I'm on linux.

[agarciar]

I'm not seeing any errors when provisioning with 2.19, can you provide any output with the errors?

This issue is also reproducible on macOS with LimaVM (v1.2.1) and the Trellis CLI (v1.14.0).

Steps to Reproduce

trellis new test-ansible.com
cd test-ansible.com
trellis vm start

Error Output

TASK [common : Fail if there are duplicate site keys within host's wordpress_sites] ***
[ERROR]: The `loop` value must resolve to a 'list', not 'str'.
Origin: /Users/agarciar/tmp/[test-ansible.com/trellis/roles/common/tasks/main.yml:18:11](https://test-ansible.com/trellis/roles/common/tasks/main.yml:18:11)

16      {{ item.site_keys | to_nice_yaml | indent(2) }}
17    when: item.site_keys | count
18    loop: "{{ site_keys_by_env_pair }}"
               ^ column 11

Provide a list of items/templates, or a template resolving to a list.

fatal: [default]: FAILED! => {"msg": "The `loop` value must resolve to a 'list', not 'str'."}

I can confirm that the solution proposed by @LucasDemea resolves this issue.

[retlehs]

Thanks y'all, turns out I wasn't actually using Ansible 2.19 because my system Python version wasn't 3.11

Confirmed the bug, will have a PR up soon