git workflow in dev container

[john-]

This is probably not a Viseron question but more of a dev container one. Feel free to point me in another direction.

I would like to push some changes to my Viseron repo. When I set up the container I used the https url to github. So I changed the remote origin url to the git@github.com location. Now, when I do anything to access that repo I get an error.

For example:

git remote show origin
error: cannot run ssh: No such file or directory
fatal: unable to fork

I don't see ssh command in the container so maybe I have the wrong workflow here. How should I be getting my changes pushed to my Viseron github repo?

[roflcoopter]

I have never been able to get that to work from inside the Devcontainer.
There are some instructions here that you could try to see if they work for you: https://code.visualstudio.com/remote/advancedcontainers/sharing-git-credentials

If you get stuck and need changes to the container please let me know and i will see what i can do.

[john-]

Thanks for the confirmation. I will take a look at that reference. You are using https to access github or some other method to push changes?

[roflcoopter]

I use my host to do push/pull since I cloned the repo manually. Am currently trying to get it to work in the container, it's important that the devcontainer works smoothly to attract more devs.

Thanks for your patience btw!

[roflcoopter]

I got it to work! All i did was follow the instructions on that page very carefully (had to use .bash_profile, not .bash) and add SSH to the container.

If you want to do that yourself you can edit the devcontainer,json like this:

{
  "name": "Viseron Development",
  "context": "..",
  "dockerFile": "../docker/Dockerfile.dev",
  "postCreateCommand": ".devcontainer/setup.sh",
  "overrideCommand": false,
  "containerEnv": {
    "DEVCONTAINER": "1",
    "VISERON_CONFIG_DIR": "${containerWorkspaceFolder}/config",
    "PUID": "1000",
    "PGID": "1000"
  },
  "containerUser": "root",
  "remoteUser": "abc",
  "forwardPorts": [8888, 1984, 8554, 8555],
  "portsAttributes": {
    "8888": {
      "label": "Viseron",
      "onAutoForward": "silent"
    },
    "1984": {
      "label": "go2rtc",
      "onAutoForward": "silent"
    },
    "8554": {
      "label": "go2rtc RTSP",
      "onAutoForward": "silent"
    },
    "8555": {
      "label": "WebRTC",
      "onAutoForward": "silent"
    }
  },
  "userEnvProbe": "loginInteractiveShell",
  "runArgs": ["-e", "GIT_EDITOR=code --wait"],
  "customizations": {
    "vscode": {
      "extensions": [
        "ms-python.python",
        "ms-python.vscode-pylance",
        "ms-python.isort",
        "ms-python.flake8",
        "ms-python.black-formatter",
        "ms-python.pylint",
        "ms-python.mypy-type-checker",
        "redhat.vscode-yaml",
        "esbenp.prettier-vscode",
        "GitHub.vscode-pull-request-github",
        "GitHub.vscode-github-actions",
        "GitHub.copilot",
        "eamodio.gitlens",
        "dbaeumer.vscode-eslint",
        "ms-azuretools.vscode-docker",
        "unifiedjs.vscode-mdx",
        "ckolkman.vscode-postgres",
        "ms-azure-devops.azure-pipelines"
      ],
      "settings": {
        "python.pythonPath": "/usr/local/bin/python",
        "python.testing.pytestArgs": ["--no-cov"],
        "isort.check": true,
        "editor.rulers": [80],
        "[python]": {
          "editor.defaultFormatter": "ms-python.black-formatter",
          "editor.rulers": [88],
          "editor.codeActionsOnSave": {
            "source.organizeImports": "explicit"
          }
        },
        "mypy-type-checker.importStrategy": "fromEnvironment",
        "pylint.importStrategy": "fromEnvironment",
        "black-formatter.importStrategy": "fromEnvironment",
        "flake8.importStrategy": "fromEnvironment",
        "isort.importStrategy": "fromEnvironment",
        "editor.formatOnPaste": false,
        "editor.formatOnSave": true,
        "editor.formatOnType": true,
        "files.trimTrailingWhitespace": true,
        "yaml.customTags": ["!secret scalar"],
        "[typescript]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "[typescriptreact]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "[json]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "[javascript]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "[mdx]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "[markdown]": {
          "editor.defaultFormatter": "esbenp.prettier-vscode"
        },
        "files.associations": {
          "**/azure-pipelines/*.yml": "azure-pipelines",
          "**/azure-pipelines/*.yaml": "azure-pipelines"
        },
        "search.exclude": {
          "**/node_modules": true,
          "**/build": true,
          "**/.docusaurus": true,
          "**/dist": true
        }
      }
    }
  },
  "features": {
    "ghcr.io/devcontainers/features/sshd:1": {}
  }
}

Cant push the changes atm so you need to add it manually

[john-]

That worked perfectly! I just overwrote devcontainer.json with the updated version you posted, saved it and then vs code prompted me to rebuild the container. That got ssh working. From there I used the usual steps of generating a ssh key and uploading the public part to github.

And as a bonus, my code changes were still there after the rebuild! :) Seriously, it is a little odd having the code in the dev container and not accessible on the host....at least I don't see it on the host in an obvious way. Next time I will probably used the clones repo approach.