question CRUD

Author: rockstarr-programmerr

classroom/filters/teacher/__init__.py

@@ -1,2 +1,3 @@
 from .classroom import ClassroomTeacherFilter
 from .exercise import ReadingExerciseTeacherFilter
+from .question import ReadingQuestionTeacherFilter

classroom/filters/teacher/question.py

@@ -0,0 +1,21 @@
+from django_filters import rest_framework as filters
+
+from classroom.models import ReadingQuestion
+
+
+class ReadingQuestionTeacherFilter(filters.FilterSet):
+    class Meta:
+        model = ReadingQuestion
+        fields = {
+            'exercise': ['exact'],
+        }
+
+    @property
+    def qs(self):
+        parent = super().qs
+        user = self.request.user
+        exercises = user.reading_exercises_created.all()
+        questions_pks = ReadingQuestion.objects.filter(exercise__in=exercises).values_list('pk', flat=True)
+        qs = parent.filter(pk__in=list(questions_pks))\
+                   .select_related('exercise__creator')
+        return qs

classroom/migrations/0005_auto_20211004_2304.py

@@ -0,0 +1,28 @@
+# Generated by Django 3.2.7 on 2021-10-04 16:04
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('classroom', '0004_alter_readingexercise_unique_together'),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name='readinganswer',
+            name='letter',
+            field=models.CharField(blank=True, max_length=10),
+        ),
+        migrations.AlterField(
+            model_name='readingquestion',
+            name='question_type',
+            field=models.CharField(choices=[('multiple_choice', 'Multiple choice'), ('true_false', 'True / False / Not given'), ('yes_no', 'Yes / No / Not given'), ('fill_blank', 'Fill in the blank')], max_length=30),
+        ),
+        migrations.AlterField(
+            model_name='readingquestion',
+            name='to_number',
+            field=models.PositiveSmallIntegerField(null=True),
+        ),
+    ]

classroom/models/abstracts/answer.py

@@ -2,7 +2,7 @@
 
 
 class Answer(models.Model):
-    letter = models.CharField(max_length=1, blank=True)
+    letter = models.CharField(max_length=10, blank=True)
     content = models.TextField()
 
     class Meta:

classroom/models/abstracts/question.py

@@ -5,14 +5,23 @@
 class Question(models.Model):
     class Types(models.TextChoices):
         MULTIPLE_CHOICE = 'multiple_choice', _('Multiple choice')
-        TRUE_FALSE = 'true_false', _('True/False/Not given')
-        YES_NO = 'yes_no', _('Yes/No/Not given')
+        TRUE_FALSE = 'true_false', _('True / False / Not given')
+        YES_NO = 'yes_no', _('Yes / No / Not given')
         FILL_BLANK = 'fill_blank', _('Fill in the blank')
 
     from_number = models.PositiveSmallIntegerField()
-    to_number = models.PositiveSmallIntegerField()
+    to_number = models.PositiveSmallIntegerField(null=True)
     question_type = models.CharField(max_length=30, choices=Types.choices)
     correct_answer = models.CharField(max_length=255)
 
     class Meta:
         abstract = True
+
+    def __str__(self):
+        return f'{self.get_question_number_display()} | {self.question_type} | {self.correct_answer[:50]}'
+
+    def get_question_number_display(self):
+        display = str(self.from_number)
+        if self.to_number is not None and self.to_number != self.from_number:
+            display += f' - {self.to_number}'
+        return display

classroom/models/reading_answer.py

@@ -9,3 +9,6 @@ class ReadingAnswer(Answer):
 
     class Meta:
         ordering = ['question', 'letter', 'pk']
+
+    def __str__(self):
+        return f'{self.letter}. {self.content[:50]}'

classroom/models/reading_exercise.py

@@ -15,3 +15,21 @@ class ReadingExercise(models.Model):
     class Meta:
         ordering = ['identifier']
         unique_together = ['creator', 'identifier']
+
+    def __str__(self):
+        display = self.identifier
+        if self.creator:
+            display += f' | {self.creator.email}'
+        return display
+
+    def get_question_range(self):
+        question_numbers = self.questions.order_by('from_number').values('from_number', 'to_number')
+        question_range = []
+        for number in question_numbers:
+            from_number = number['from_number']
+            to_number = number['to_number']
+            if to_number is None:
+                question_range.append(from_number)
+            else:
+                question_range.extend(range(from_number, to_number + 1))
+        return question_range

classroom/permissions.py

@@ -32,6 +32,16 @@ def has_object_permission(self, request, view, exercise):
         )
 
 
+class IsTeacherOwnsQuestion(IsTeacher):
+    message = _('Only teacher who owns this question has permission for this.')
+
+    def has_object_permission(self, request, view, question):
+        return (
+            super().has_object_permission(request, view, question) and
+            request.user == question.exercise.creator
+        )
+
+
 class IsStudent(IsAuthenticated):
     message = _('Only student has permission for this.')
 

classroom/serializers/teacher/__init__.py

@@ -3,3 +3,4 @@
                         RemoveReadingExerciseSerializer,
                         RemoveStudentSerializer)
 from .exercise import ReadingExerciseSerializer
+from .question import ReadingQuestionSerializer

classroom/serializers/teacher/question.py

@@ -0,0 +1,57 @@
+from django.utils.translation import gettext as _
+from rest_framework import serializers
+
+from classroom.models import ReadingQuestion
+
+
+class ReadingQuestionSerializer(serializers.HyperlinkedModelSerializer):
+    class Meta:
+        model = ReadingQuestion
+        fields = [
+            'pk', 'url', 'exercise',
+            'from_number', 'to_number', 'question_type', 'correct_answer',
+        ]
+        extra_kwargs = {
+            'url': {'view_name': 'reading-question-teacher-detail'},
+            'exercise': {'view_name': 'reading-exercise-teacher-detail'},
+            'from_number': {'min_value': 1},
+            'to_number': {'min_value': 1},
+        }
+
+    def validate(self, attrs):
+        attrs = super().validate(attrs)
+        self._validate_from_to_number(attrs)
+        self._validate_question_not_exist(attrs)
+        return attrs
+
+    def _validate_from_to_number(self, attrs):
+        from_number = attrs['from_number']
+        to_number = attrs['to_number']
+        if to_number is not None and not to_number > from_number:
+            raise serializers.ValidationError(
+                _('"To" must be greater than "From".')
+            )
+
+    def _validate_question_not_exist(self, attrs):
+        from_number = attrs['from_number']
+        exercise = attrs['exercise']
+        question_range = exercise.get_question_range()
+
+        if self.instance:
+            if self.instance.to_number is not None:
+                instance_range = range(self.instance.from_number, self.instance.to_number + 1)
+            else:
+                instance_range = [self.instance.from_number]
+            for number in instance_range:
+                try:
+                    index = question_range.index(number)
+                    question_range.pop(index)
+                except ValueError:
+                    pass
+
+        if from_number in question_range:
+            raise serializers.ValidationError(
+                _('This question number already exists.')
+            )
+
+    # TODO: validation regarding `question_type` and `correct_answer`