Skip to content

Commit 6aecffe

Browse files
fix permission and serializer
1 parent c8dd62d commit 6aecffe

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

account/serializers.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ class Meta(UserSerializer.Meta):
3737
extra_kwargs = {
3838
'password': {'write_only': True},
3939
'avatar_thumbnail': {'read_only': True},
40+
'name': {'required': False},
41+
'phone_number': {'required': False},
42+
'avatar': {'required': False},
4043
}
4144

4245

classroom/permissions.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ class IsTeacherOrReadOnly(IsAuthenticated):
77

88
def has_permission(self, request, view):
99
is_authenticated = super().has_permission(request, view)
10-
is_teacher = request.user.is_teacher()
1110
return (
1211
is_authenticated and (
13-
request.method in SAFE_METHODS or is_teacher
12+
request.method in SAFE_METHODS or
13+
request.user.is_teacher()
1414
)
1515
)
1616

keep_learning/views.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ def get(self, request):
1111
if request.user.is_authenticated:
1212
data = {
1313
'account': request.build_absolute_uri('/account/'),
14-
'teacher': {
15-
'classroom': request.build_absolute_uri('/classroom/'),
16-
}
14+
'classroom': request.build_absolute_uri('/classroom/'),
1715
}
1816
else:
1917
data = {

0 commit comments

Comments
 (0)