Skip to content

Commit 1048dbf

Browse files
having fun
1 parent e6a05b6 commit 1048dbf

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

classroom/serializers/classroom.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,29 @@
66
from classroom.utils.serializer import ValidateUniqueTogetherMixin
77

88

9+
class _ReadingExerciseSerializer(serializers.HyperlinkedModelSerializer):
10+
class Meta:
11+
model = ReadingExercise
12+
fields = ['pk', 'url', 'identifier']
13+
extra_kwargs = {
14+
'url': {'view_name': 'reading-exercise-detail'},
15+
}
16+
17+
918
class ClassroomSerializer(ValidateUniqueTogetherMixin, serializers.HyperlinkedModelSerializer):
1019
teacher = UserSerializer(read_only=True)
1120
students = UserSerializer(many=True, read_only=True)
12-
reading_exercises = serializers.PrimaryKeyRelatedField(
13-
queryset=ReadingExercise.objects.all(),
14-
many=True,
15-
)
21+
reading_exercises = _ReadingExerciseSerializer(many=True, read_only=True)
1622

1723
class Meta:
1824
model = Classroom
1925
fields = [
2026
'pk', 'url', 'name', 'description', 'create_datetime',
2127
'teacher', 'students', 'reading_exercises',
2228
]
23-
read_only_fields = [
24-
'create_datetime', 'teacher',
25-
'students', 'reading_exercises'
26-
]
29+
read_only_fields = ['create_datetime']
2730
extra_kwargs = {
2831
'url': {'view_name': 'classroom-detail'},
29-
# 'reading_exercises': {'view_name': 'reading-exercise-detail'},
3032
}
3133

3234
def validate_name(self, name):

0 commit comments

Comments
 (0)