-
-
Notifications
You must be signed in to change notification settings - Fork 6
Open
Labels
C-command-linecategory: Command-line toolscategory: Command-line toolsC-grpccategory: gRPC supportcategory: gRPC supportgood first issueTask good for newcomersTask good for newcomershelp wantedLooking for contributorsLooking for contributors
Description
roc-vad logcat command streams logs from driver and prints them to console.
Currently it prints all messages. It would be convenient to add an option to print messages only of specified log level and below. For example, --level=3 would print only messages with levels CRIT, ERROR, WARN, INFO, and suppress DEBUG and TRACE messages. It would be nice to accept both numeric value, like --level=3 and its string shorthand, like --level=II. (Short-hands are: CC, EE, WW, II, DD, TT).
Filtering should be done on the driver side, so that extensive debug logs are not streamed if they're not needed. Hence we need to add log level parameter to stream_logs() rpc call and handle it in rpc server inside driver.
Related files:
rpc/driver_protocol.protodefinesstream_logs()call and available log levelstool/cmd_logcat.cpp- implementslogcatcommand on the client side that callsstream_logs()driver/driver_service.cpp- implementsstream_logs()call in the rpc service
Metadata
Metadata
Assignees
Labels
C-command-linecategory: Command-line toolscategory: Command-line toolsC-grpccategory: gRPC supportcategory: gRPC supportgood first issueTask good for newcomersTask good for newcomershelp wantedLooking for contributorsLooking for contributors