feat(history): cache the root folders in the store (#23)

* feat(history): cache the root folders in the store

* version bump

Author: robertohuertasm

package-lock.json

@@ -2,7 +2,7 @@
   "name": "open-vscode",
   "displayName": "vscode-open",
   "description": "Open Visual Studio Code with a URL",
-  "version": "1.1.4",
+  "version": "1.1.5",
   "publisher": "robertohuertasm",
   "license": "MIT",
   "author": {

package.json

@@ -6,6 +6,7 @@ import {
   getOpenedRepoHistory,
   removeOpenedRepoFromHistory,
   resetPendingUriToOpen,
+  addOpenedRepoToHistory,
 } from './repoHistory';
 
 // The kind of URIS we are handling will be like this:
@@ -130,15 +131,7 @@ export class Opener {
   }
 
   private async openNewWorkspace(forceNewWindow = false) {
-    // has this repo been ever opened?
-    const knownRepoInfo = await getOpenedRepoHistory(this.context);
-    const knownRepo = knownRepoInfo[this.repoName];
-    console.log(`knownRepo ${this.repoName}: ${knownRepo}`);
-    // if the repo is not found in the history, we're going to search for it in the config roots
-    const repoPath = knownRepo
-      ? vscode.Uri.file(knownRepo)
-      : await this.findFolderInConfigRoots();
-
+    const repoPath = await this.findFolderInSources();
     if (this.file) {
       // NOTE: opening a folder causes the extension to reload again.
       // This means that if you want to open a file, you need to do it on extension activation.
@@ -152,6 +145,30 @@ export class Opener {
     await this.openFolder(repoPath, forceNewWindow);
   }
 
+  private async findFolderInSources(): Promise<vscode.Uri | undefined> {
+    // has this repo been ever opened?
+    const knownRepoInfo = await getOpenedRepoHistory(this.context);
+    const knownRepo = knownRepoInfo[this.repoName];
+    console.log(`knownRepo ${this.repoName}: ${knownRepo}`);
+    // if the repo is not found in the history, we're going to search for it in the config roots
+    if (knownRepo) {
+      return vscode.Uri.file(knownRepo);
+    }
+    const repoInRootsUri = await this.findFolderInConfigRoots();
+    if (repoInRootsUri) {
+      // we're going to store the repo in the history
+      await addOpenedRepoToHistory(
+        {
+          name: this.repoName,
+          uri: repoInRootsUri,
+        },
+        this.context,
+      );
+      return repoInRootsUri;
+    }
+    return undefined;
+  }
+
   private async getCurrentCommit(
     repo: Repository,
   ): Promise<Branch | undefined> {

src/opener.ts

@@ -3,25 +3,30 @@ import * as vscode from 'vscode';
 const OPENED_REPO_HISTORY_KEY = 'openedRepoHistory';
 const PENDING_URI_TO_OPEN = 'vscode-open.last-uri';
 
+export interface HistoryRecord {
+  readonly name: string;
+  readonly uri: vscode.Uri;
+}
+
 export async function getOpenedRepoHistory(
   context: vscode.ExtensionContext,
 ): Promise<Record<string, string | undefined>> {
   return (await context.globalState.get(OPENED_REPO_HISTORY_KEY)) || {};
 }
 
 export async function addOpenedRepoToHistory(
-  folder: vscode.WorkspaceFolder,
+  record: HistoryRecord,
   context: vscode.ExtensionContext,
 ): Promise<void> {
   const repos = await getOpenedRepoHistory(context);
-  repos[folder.name] = folder.uri.fsPath;
+  repos[record.name] = record.uri.fsPath;
   await context.globalState.update(OPENED_REPO_HISTORY_KEY, repos);
   // re-check, there are some cases where this might not work
   const check = await getOpenedRepoHistory(context);
-  if (!check[folder.name]) {
-    console.error(`Failed to save ${folder.name} to repo history`);
+  if (!check[record.name]) {
+    console.error(`Failed to save ${record.name} to repo history`);
   } else {
-    console.log(`Added repo ${folder.name} to the repo history`);
+    console.log(`Added repo ${record.name} to the repo history`);
   }
 }