Skip to content

Commit 906c9b1

Browse files
committed
Merge branch 'master' into feature/argument-deprecation
# Conflicts: # spec/graphql/schema/argument_spec.rb
2 parents 253a8c5 + 2b77ee2 commit 906c9b1

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+496
-104
lines changed

CHANGELOG.md

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,42 @@
88

99
### Bug fixes
1010

11+
## 1.11.4 (24 August 2020)
12+
13+
### Breaking changes
14+
15+
### New features
16+
17+
- Add `node_nullable` option for `edge_type` #3083
18+
- Use module namespacing for template generators #3098
19+
20+
### Bug fixes
21+
22+
- Rescue `SystemStackError`s during validation #3107
23+
- Add `require 'digest/sha2'` for fingerprint #3103
24+
- Optimize `GraphQL::Query::Context#dig` #3090
25+
- Check if new connections before calling method on it (fixes #3059) #3100
26+
- Thread field owner type through interpreter runtime (fixes #3086) #3099
27+
- Check for visible interfaces on the type in warden #3096
28+
- Update `AppOpticsTracing` with latest changes in `PlatformTracing` #3097
29+
- Use throw instead of raise to halt subscriptions early #3084
30+
- Optimize `GraphQL::Query::Context#fetch` #3081
31+
32+
## 1.11.3 (13 August 2020)
33+
34+
### Breaking changes
35+
36+
- Reverted the `required` and `default_value` argument behaviour change in 1.11.2 since it was not spec compliant #3066
37+
38+
### New features
39+
40+
- Improve resolver method conflict warning #3069, #3062
41+
- Store arguments on `Mutation` instances after they're loaded #3073
42+
43+
### Bug fixes
44+
45+
- Fix connection wrappers on lazy lists #3070
46+
1147
## 1.11.2 (1 August 2020)
1248

1349
### Breaking changes

guides/fields/introduction.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ field :scores, [Integer, null: true], null: true # `[Int]`, may return a list or
5252

5353
### Field Documentation
5454

55-
Fields maybe documented with a __description__ and may be __deprecated__.
55+
Fields may be documented with a __description__ and may be __deprecated__.
5656

5757
__Descriptions__ can be added with the `field(...)` method as a positional argument, a keyword argument, or inside the block:
5858

guides/related_projects.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ Want to add something? Please open a pull request [on GitHub](https://github.com
1616
- [`graphql-batch`](https://github.com/shopify/graphql-batch), a batched query execution strategy
1717
- [`graphql-cache`](https://github.com/stackshareio/graphql-cache), a resolver-level caching solution
1818
- [`graphql-libgraphqlparser`](https://github.com/rmosolgo/graphql-libgraphqlparser-ruby), bindings to [libgraphqlparser](https://github.com/graphql/libgraphqlparser), a C-level parser.
19+
- [`graphql-devise`](https://github.com/graphql-devise/graphql_devise), a gql interface to handle authentication with Devise
1920
- [`graphql-docs`](https://github.com/gjtorikian/graphql-docs), a tool to automatically generate static HTML documentation from your GraphQL implementation
2021
- [`graphql-metrics`](https://github.com/Shopify/graphql-metrics), a plugin to extract fine-grain metrics of GraphQL queries received by your server
2122
- [`graphql-groups`](https://github.com/hschne/graphql-groups), a DSL to define group- and aggregation queries with graphql-ruby

guides/relay/connections.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ class Types::PostConnectionWithTotalCountType < GraphQL::Types::Relay::BaseConne
8989
end
9090
```
9191

92-
__Note:__ If you use _classes_ for an object's connection or edge types, then all of that object's connection and edge types should be classes. Otherwise, the auto-generated types from the `.edge_type` or `.connection_type` helpers will conflict with the class-based types.
93-
9492
Now, you can use `PostConnectionWithTotalCountType` to define a connection with the "totalCount" field:
9593

9694
```ruby

guides/subscriptions/ably_implementation.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,11 @@ end
184184
4. Click on the "+ New Reactor Rule" button
185185
5. Click on the "Choose" button for "Reactor Event"
186186
6. Click on the "Choose" button for "WebHooks"
187-
7. Enter your url (including the webhooks path from above) in the URL field
188-
8. Under "Source" select "Channel Lifecycle"
189-
9. Under "Sign with key" select the API Key prefix that matches the prefix of the ABLY_API_KEY you provided.
190-
10. Click "Create"
187+
7. Enter your url (including the webhooks path from above) in the URL field.
188+
8. Select "Batch request" for "Request Mode"
189+
9. Under "Source" select "Channel Lifecycle"
190+
10. Under "Sign with key" select the API Key prefix that matches the prefix of the ABLY_API_KEY you provided.
191+
11. Click "Create"
191192

192193
## Authorization
193194

guides/type_definitions/interfaces.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ end
120120

121121
Those object types will _inherit_ field definitions from those interfaces.
122122

123-
If you add an object type which implements an interface, but that object type doesn't properly appear in your schema, then you need to add that object to the interfaces's `orphan_types`.
123+
If you add an object type which implements an interface, but that object type doesn't appear in your schema as a field return type, a union member, or a root type, then you need to add that object to the interfaces's `orphan_types`.
124124

125125
### Implementing Fields
126126

lib/generators/graphql/core.rb

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,14 @@ def create_dir(dir)
4141
end
4242
end
4343

44+
def module_namespacing_when_supported
45+
if defined?(module_namespacing)
46+
module_namespacing { yield }
47+
else
48+
yield
49+
end
50+
end
51+
4452
private
4553

4654
def schema_name
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
<% module_namespacing_when_supported do -%>
12
module Types
23
class BaseArgument < GraphQL::Schema::Argument
34
end
45
end
6+
<% end -%>
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1+
<% module_namespacing_when_supported do -%>
12
module Types
23
class BaseEnum < GraphQL::Schema::Enum
34
end
45
end
6+
<% end -%>
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
1+
<% module_namespacing_when_supported do -%>
12
module Types
23
class BaseField < GraphQL::Schema::Field
34
argument_class Types::BaseArgument
45
end
56
end
7+
<% end -%>

0 commit comments

Comments
 (0)