fix: handle response encode error (resolve discussion_r1936947554)

rluders · rluders · commit 0c031ff0079d · 2025-01-31T10:44:12.000+01:00
diff --git a/response.go b/response.go
@@ -85,5 +85,7 @@ func SendResponse[T any](w http.ResponseWriter, code int, data T, problem *Probl
 func writeProblemDetail(w http.ResponseWriter, code int, problem *ProblemDetails) {
 	w.Header().Set("Content-Type", "application/problem+json; charset=utf-8")
 	w.WriteHeader(problem.Status)
-	_ = json.NewEncoder(w).Encode(problem)
+	if err := json.NewEncoder(w).Encode(problem); err != nil {
+		log.Printf("Failed to encode problem details: %v", err)
+	}
 }

Original file line number	Diff line number	Diff line change
`@@ -85,5 +85,7 @@ func SendResponse[T any](w http.ResponseWriter, code int, data T, problem *Probl`
`85`	`85`	`func writeProblemDetail(w http.ResponseWriter, code int, problem *ProblemDetails) {`
`86`	`86`	`w.Header().Set("Content-Type", "application/problem+json; charset=utf-8")`
`87`	`87`	`w.WriteHeader(problem.Status)`
`88`		`- _ = json.NewEncoder(w).Encode(problem)`
	`88`	`+ if err := json.NewEncoder(w).Encode(problem); err != nil {`
	`89`	`+ log.Printf("Failed to encode problem details: %v", err)`
	`90`	`+ }`
`89`	`91`	`}`