[InstCombine] Create Icmp in canonical form (NFC) (llvm#146266)

andjo403 · rlavaee · commit 146c4148898f · 2025-07-01T16:03:57.000Z
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp b/llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp
@@ -681,7 +681,7 @@ static Value *foldLogOpOfMaskedICmps(Value *LHS, Value *RHS, bool IsAnd,
         }
         Value *NewAnd = Builder.CreateAnd(A, BD);
         Value *CEVal = ConstantInt::get(A->getType(), CE);
-        return Builder.CreateICmp(CC, CEVal, NewAnd);
+        return Builder.CreateICmp(CC, NewAnd, CEVal);
       };
 
       if (Mask & BMask_Mixed)

Original file line number	Diff line number	Diff line change
`@@ -681,7 +681,7 @@ static Value foldLogOpOfMaskedICmps(Value LHS, Value *RHS, bool IsAnd,`
`681`	`681`	`}`
`682`	`682`	`Value *NewAnd = Builder.CreateAnd(A, BD);`
`683`	`683`	`Value *CEVal = ConstantInt::get(A->getType(), CE);`
`684`		`- return Builder.CreateICmp(CC, CEVal, NewAnd);`
	`684`	`+ return Builder.CreateICmp(CC, NewAnd, CEVal);`
`685`	`685`	`};`
`686`	`686`
`687`	`687`	`if (Mask & BMask_Mixed)`