chore: remove transport negotiation

Author: NathanFlurry

docs/concepts/interacting-with-actors.mdx

@@ -569,7 +569,6 @@ Other common errors you might encounter:
 
 - `InternalError`: Error from your actor that's not a subclass of `UserError`
 - `ManagerError`: Issues when connecting to or communicating with the actor manager
-- `NoSupportedTransport`: When the client and server have no compatible transport
 
 ## Disconnecting and Cleanup
 

packages/actor-core/src/client/actor_conn.ts

@@ -116,8 +116,7 @@ export class ActorConnRaw {
 		private readonly endpoint: string,
 		private readonly params: unknown,
 		private readonly encodingKind: Encoding,
-		private readonly supportedTransports: Transport[],
-		private readonly serverTransports: Transport[],
+		private readonly transport: Transport,
 		private readonly actorQuery: ActorQuery,
 	) {
 		this.#keepNodeAliveInterval = setInterval(() => 60_000);
@@ -349,13 +348,12 @@ enc
 			this.#onOpenPromise = Promise.withResolvers();
 
 			// Connect transport
-			const transport = this.#pickTransport();
-			if (transport === "websocket") {
+			if (this.transport === "websocket") {
 				this.#connectWebSocket();
-			} else if (transport === "sse") {
+			} else if (this.transport === "sse") {
 				this.#connectSse();
 			} else {
-				assertUnreachable(transport);
+				assertUnreachable(this.transport);
 			}
 
 			// Wait for result
@@ -365,19 +363,6 @@ enc
 		}
 	}
 
-	#pickTransport(): Transport {
-		// Choose first supported transport from server's list that client also supports
-		const transport = this.serverTransports.find((t) =>
-			this.supportedTransports.includes(t),
-		);
-
-		if (!transport) {
-			throw new errors.NoSupportedTransport();
-		}
-
-		return transport;
-	}
-
 	#connectWebSocket() {
 		const { WebSocket } = this.#dynamicImports;
 

packages/actor-core/src/client/client.ts

@@ -63,7 +63,7 @@ export interface ActorAccessor<AD extends AnyActorDefinition> {
  */
 export interface ClientOptions {
 	encoding?: Encoding;
-	supportedTransports?: Transport[];
+	transport?: Transport;
 }
 
 /**
@@ -140,7 +140,7 @@ export class ClientRaw {
 
 	#managerEndpoint: string;
 	#encodingKind: Encoding;
-	#supportedTransports: Transport[];
+	#transport: Transport;
 
 	/**
 	 * Creates an instance of Client.
@@ -153,10 +153,7 @@ export class ClientRaw {
 		this.#managerEndpoint = managerEndpoint;
 
 		this.#encodingKind = opts?.encoding ?? "cbor";
-		this.#supportedTransports = opts?.supportedTransports ?? [
-			"websocket",
-			"sse",
-		];
+		this.#transport = opts?.transport ?? "websocket";
 	}
 
 	/**
@@ -185,12 +182,7 @@ export class ClientRaw {
 		};
 
 		const managerEndpoint = this.#managerEndpoint;
-		const conn = this.#createConn(
-			managerEndpoint,
-			opts?.params,
-			["websocket", "sse"],
-			actorQuery,
-		);
+		const conn = this.#createConn(managerEndpoint, opts?.params, actorQuery);
 		return this.#createProxy(conn) as ActorConn<AD>;
 	}
 
@@ -261,7 +253,6 @@ export class ClientRaw {
 		const conn = this.#createConn(
 			managerEndpoint,
 			opts?.params,
-			["websocket", "sse"],
 			actorQuery,
 		);
 		return this.#createProxy(conn) as ActorConn<AD>;
@@ -324,28 +315,21 @@ export class ClientRaw {
 		};
 
 		const managerEndpoint = this.#managerEndpoint;
-		const conn = this.#createConn(
-			managerEndpoint,
-			opts?.params,
-			["websocket", "sse"],
-			actorQuery,
-		);
+		const conn = this.#createConn(managerEndpoint, opts?.params, actorQuery);
 		return this.#createProxy(conn) as ActorConn<AD>;
 	}
 
 	#createConn(
 		endpoint: string,
 		params: unknown,
-		serverTransports: Transport[],
 		actorQuery: ActorQuery,
 	): ActorConnRaw {
 		const conn = new ActorConnRaw(
 			this,
 			endpoint,
 			params,
 			this.#encodingKind,
-			this.#supportedTransports,
-			serverTransports,
+			this.#transport,
 			actorQuery,
 		);
 		this[ACTOR_CONNS_SYMBOL].add(conn);

packages/actor-core/src/client/errors.ts

@@ -24,12 +24,6 @@ export class MalformedResponseMessage extends ActorClientError {
 	}
 }
 
-export class NoSupportedTransport extends ActorClientError {
-	constructor() {
-		super("No supported transport available between client and server");
-	}
-}
-
 export class ActionError extends ActorClientError {
 	constructor(
 		public readonly code: string,

packages/actor-core/src/client/mod.ts

@@ -24,7 +24,6 @@ export {
 	ManagerError,
 	ConnParamsTooLong,
 	MalformedResponseMessage,
-	NoSupportedTransport,
 	ActionError,
 	ConnectionError,
 } from "@/client/errors";