Skip to content

Commit 505dddd

Browse files
committed
Avoid nested loop while using nikic/php-parser
1 parent dd7eb46 commit 505dddd

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/Ast/Converter.php

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,19 +27,18 @@ public function convert(iterable $listings): ConverterResult
2727
{
2828
$converterResult = new ConverterResult();
2929

30+
$traverser = new NodeTraverser();
31+
foreach ($this->visitors as $visitor) {
32+
$traverser->addVisitor($visitor);
33+
}
34+
3035
foreach ($listings as $listing) {
3136
$ast = $this->parser->parse($listing);
32-
$traverser = new NodeTraverser();
33-
34-
foreach ($this->visitors as $visitor) {
35-
$traverser->addVisitor($visitor);
36-
}
37-
3837
$traverser->traverse($ast);
38+
}
3939

40-
foreach ($this->visitors as $visitor) {
41-
$converterResult->merge($visitor->popResult());
42-
}
40+
foreach ($this->visitors as $visitor) {
41+
$converterResult->merge($visitor->popResult());
4342
}
4443

4544
return $converterResult;

0 commit comments

Comments
 (0)