Skip to content

Commit 73cbf0f

Browse files
author
Liang Zhao
committed
DataChunk::from_rows
1 parent 29b4c43 commit 73cbf0f

File tree

2 files changed

+19
-32
lines changed

2 files changed

+19
-32
lines changed

dashboard/proto/gen/stream_plan.ts

Lines changed: 8 additions & 19 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/stream/src/executor/now.rs

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,10 @@ use async_stack_trace::StackTrace;
1616
use chrono::NaiveDateTime;
1717
use futures::{pin_mut, StreamExt};
1818
use futures_async_stream::try_stream;
19-
use risingwave_common::array::{Op, StreamChunk};
19+
use risingwave_common::array::{DataChunk, Op, StreamChunk};
2020
use risingwave_common::catalog::{Field, Schema};
2121
use risingwave_common::row::Row;
2222
use risingwave_common::types::{DataType, NaiveDateTimeWrapper, ScalarImpl};
23-
use risingwave_common::util::chunk_coalesce::DataChunkBuilder;
2423
use risingwave_common::util::epoch::Epoch;
2524
use risingwave_storage::StateStore;
2625
use tokio::sync::mpsc::UnboundedReceiver;
@@ -106,18 +105,17 @@ impl<S: StateStore> NowExecutor<S> {
106105
),
107106
)));
108107

109-
let mut data_chunk_builder = DataChunkBuilder::new(
110-
schema.data_types(),
111-
if last_timestamp.is_some() { 2 } else { 1 },
108+
let data_chunk = DataChunk::from_rows(
109+
&if last_timestamp.is_some() {
110+
vec![
111+
Row::new(vec![last_timestamp.clone()]),
112+
Row::new(vec![timestamp.clone()]),
113+
]
114+
} else {
115+
vec![Row::new(vec![timestamp.clone()])]
116+
},
117+
&schema.data_types(),
112118
);
113-
if last_timestamp.is_some() {
114-
let chunk_popped = data_chunk_builder
115-
.append_one_row_from_datums([&last_timestamp].into_iter());
116-
debug_assert!(chunk_popped.is_none());
117-
}
118-
let data_chunk = data_chunk_builder
119-
.append_one_row_from_datums([&timestamp].into_iter())
120-
.unwrap();
121119
let mut ops = if last_timestamp.is_some() {
122120
vec![Op::Delete]
123121
} else {

0 commit comments

Comments
 (0)