Skip to content

Incorrect use of "hasresethaltreq" in section 4.6 #1144

@pdonahue-ventana

Description

@pdonahue-ventana

When looking at #1142, I noticed that the use of "hasresethaltreq" is completely wrong in section 4.6 (https://github.com/riscv/riscv-debug-spec/blob/main/Sdext.adoc?plain=1#L171). It should refer to the actual resethaltreq bit rather than the field that says whether the resethaltreq bit exists.

The LaTeX was correct: https://github.com/riscv/riscv-debug-spec/blob/latex/Sdext.tex#L166 and it was broken by a manual edit during the adoc conversion process: 302f880#diff-2875d33a4b0e40137132883c0f9990619f83d859df46e1f650dee12d2bac5f40L166

If anybody did what's written in the adoc spec then the fact that the DM simply supports resethaltreq would mean that every reset would halt regardless of the state of resethaltreq. That doesn't make sense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions