Skip to content

Commit 9c2d73a

Browse files
committed
target/riscv: update repeat_read documentation
Updated repeat_read documentation according to new behaviour Change-Id: Ie6ea3df4df3e208fa74cf2c9d53230d460a11db6 Signed-off-by: Farid Khaydari <f.khaydari@syntacore.com>
1 parent c8afa09 commit 9c2d73a

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

doc/openocd.texi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11465,9 +11465,9 @@ dump_sample_buf}.
1146511465
@end deffn
1146611466

1146711467
@deffn {Command} {riscv repeat_read} count address [size=4]
11468-
Quickly read count words of the given size from address. This can be useful
11469-
to read out a buffer that's memory-mapped to be accessed through a single
11470-
address, or to sample a changing value in a memory-mapped device.
11468+
Quickly read count words of the given size from physical address. This can
11469+
be useful to read out a buffer that's memory-mapped to be accessed through
11470+
a single address, or to sample a changing value in a memory-mapped device.
1147111471
@end deffn
1147211472

1147311473
@deffn {Command} {riscv info}

src/target/riscv/riscv.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5229,6 +5229,8 @@ COMMAND_HANDLER(handle_repeat_read)
52295229
.count = count,
52305230
.increment = 0,
52315231
};
5232+
/* TODO: Add a command parameter that enables
5233+
choosing between virtual and physical access */
52325234
int result = r->access_memory(target, args, /* is_virtual */ false);
52335235
if (result == ERROR_OK) {
52345236
target_handle_md_output(cmd, target, address, size, count, buffer,
@@ -5612,7 +5614,7 @@ static const struct command_registration riscv_exec_command_handlers[] = {
56125614
.handler = handle_repeat_read,
56135615
.mode = COMMAND_ANY,
56145616
.usage = "count address [size=4]",
5615-
.help = "Repeatedly read the value at address."
5617+
.help = "Repeatedly read the value at physical address."
56165618
},
56175619
{
56185620
.name = "set_command_timeout_sec",

0 commit comments

Comments
 (0)