Skip to content

Commit 68a48d2

Browse files
committed
CI: Use merge time for activity check
The activity check of the nightly release pipeline extracts the field 'commit.author.date' from the top commit to decide if commit was added in the last 24 hours. However, unless PRs are reviewed and merged within 24 hours this activity check will fail. Using the date of the merge instead leads to a more robust activity check. To give a concrete example, here are the top lines of today's commit log: ``` { "sha": "a14abe3265ae8bd3ce463aefa4645bd376d08e5a", "node_id": "C_kwDOAWrbKtoAKGExNGFiZTMyNjVhZThiZDNjZTQ2M2FlZmE0NjQ1YmQzNzZkMDhlNWE", "commit": { "author": { "name": "Christoph Müllner", "email": "christoph.muellner@vrull.eu", "date": "2024-10-12T22:54:57Z" }, "committer": { "name": "Christoph Müllner", "email": "christophm30@gmail.com", "date": "2024-10-16T08:08:11Z" }, [...] ``` The existing code extracts the following time: ``` $ jq -r '.commit.author.date' commit.json 2024-10-12T22:54:57Z ``` The code change in this PR changes this to the following: ``` $ jq -r '.commit.committer.date' commit.json 2024-10-16T08:08:11Z ``` Signed-off-by: Christoph Müllner <christoph.muellner@vrull.eu>
1 parent 935b263 commit 68a48d2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/nightly-release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
id: activity_check
1717
run: |
1818
curl -sL https://api.github.com/repos/$GITHUB_REPOSITORY/commits | jq -r '[.[]][0]' > $HOME/commit.json
19-
date="$(jq -r '.commit.author.date' $HOME/commit.json)"
19+
date="$(jq -r '.commit.committer.date' $HOME/commit.json)"
2020
timestamp=$(date --utc -d "$date" +%s)
2121
author="$(jq -r '.commit.author.name' $HOME/commit.json)"
2222
url="$(jq -r '.html_url' $HOME/commit.json)"

0 commit comments

Comments
 (0)