Deep Cloning

[fredericoregateiro]

Hi everyone,

Could mapperly be used to deep clone one object?
Something like this:

[Mapper(UseDeepCloning = true)]
public partial class DocumentMapper
{
    public partial Document Map(Document doc);
}

public class Document
{
    public int Id { get; set; }
    public string Name { get; set; }
    public string Description { get; set; }
}

The code generated is like this:

public partial global::ConsoleAppMapperly.Document? Map(global::ConsoleAppMapperly.Document? doc)
{
    if (doc == null)
        return default;
    var target = new global::ConsoleAppMapperly.Document();
    target.Name = doc.Name;
    target.Description = doc.Description;
    return target;
}

The Id is not mapped, why?

[TimothyMakkison]

That's strange I can't replicate this. Which version of mapperly are you using?

// Assuming nullable is disabled
public partial class DocumentMapper
{
    public partial global::Riok.Mapperly.Sample.Document? Map(global::Riok.Mapperly.Sample.Document? doc)
    {
        if (doc == null)
            return default;
        var target = new global::Riok.Mapperly.Sample.Document();
        target.Id = doc.Id;
        target.Name = doc.Name;
        target.Description = doc.Description;
        return target;
    }
}

[TimothyMakkison]

Thanks for the update. I've managed to replicated your bug 👍 I'll try some different versions of Mapperly and then try to find the issue.

Update: tested 2.8, 2.7 and 2.6 and they all fail. I'm suprised an integration test didn't catch this.

[TimothyMakkison]

Thanks again for the help. This issue is known and has been fixed via #388, see also #362.

You can find the preview version with the fix here.

[fredericoregateiro]

I got the same result with version 2.8.0-next.2.
As a side note, the nuget manager shows 2.8.0-next.2 as a previous version of 2.8.0

[latonz]

The fix for this bug is merged into main but not yet released. A preview release will be published in the upcoming days including the fix in question.

[TimothyMakkison]

Ah yeah, mb. I think VS caching tricked me 😐

[latonz]

2.9.0-next.1 is now released including this bug fix.

[fredericoregateiro]

Just tested the 2.9.0-next.1, and it wasn't working until i restarted VS 🔮

Now it's working in .net framework 4.8, .net 7 and .net standard 2.0 and producing the same code 👏