#42: refactoring after review

Author: devromik

metrics-facade-base/src/main/java/com/ringcentral/platform/metrics/AbstractMetricRegistry.java

@@ -242,7 +242,7 @@ protected AbstractMetricRegistry(
     }
 
     public static ScheduledExecutorService makeDefaultExecutor() {
-        return newSingleThreadScheduledExecutor(new BasicThreadFactory("metric-registry-executor-%d"));
+        return newSingleThreadScheduledExecutor(new BasicThreadFactory("metric-registry-executor-%d", true));
     }
 
     public static PredicativeMetricNamedInfoProvider<MetricMod> makeDefaultModsProvider() {

metrics-facade-base/src/main/java/com/ringcentral/platform/metrics/utils/BasicThreadFactory.java

@@ -13,8 +13,8 @@ public class BasicThreadFactory implements ThreadFactory {
     private final boolean daemon;
     private final AtomicInteger threadNumber = new AtomicInteger(1);
 
-    public BasicThreadFactory(String namePattern) {
-        this(Executors.defaultThreadFactory(), namePattern, true);
+    public BasicThreadFactory(String namePattern, boolean daemon) {
+        this(Executors.defaultThreadFactory(), namePattern, daemon);
     }
 
     public BasicThreadFactory(ThreadFactory parent, String namePattern, boolean daemon) {

metrics-facade-base/src/main/java/com/ringcentral/platform/metrics/utils/StringUtils.java

@@ -4,6 +4,10 @@ public class StringUtils {
 
     public static final String EMPTY_STRING = "";
 
+    public static boolean isNotBlank(final CharSequence cs) {
+        return !isBlank(cs);
+    }
+
     /**
      * Checks if a CharSequence is null, empty, or contains only whitespace characters (Character.isWhitespace(char) == true).
      *
@@ -35,10 +39,6 @@ public static boolean isBlank(CharSequence cs) {
         return true;
     }
 
-    public static boolean isNotBlank(final CharSequence cs) {
-        return !isBlank(cs);
-    }
-
     /**
      * Splits a given string into an array of substrings divided by the dot (.) character.
      */