feat(NumberPicker): Add role=spinbutton to achieve A11y requirement

CodingOnDesk · 233mawile-rc · commit d6ec8ee0b4d4 · 2025-03-13T13:53:49.000+08:00
diff --git a/packages/juno-core/src/components/Forms/Picker/TimePicker/NumberPicker.tsx b/packages/juno-core/src/components/Forms/Picker/TimePicker/NumberPicker.tsx
@@ -235,6 +235,7 @@ const _NumberPicker = forwardRef<NumberPickerRef, NumberPickerProps>(
         aria-label={label}
         ref={pickerRef}
         data-focusable
+        role="spinbutton"
         {...rest}
       >
         <StyledTimeIconButton
diff --git a/sync-github.json b/sync-github.json
@@ -1,3 +1,3 @@
 {
-  "latestCommitSHA": "a883158ada835e11be8ad15d5f1e6e4eecf30f01"
+  "latestCommitSHA": "b902d2225a72447f071e2d74b48ad14c479dc8fa"
 }

Original file line number	Diff line number	Diff line change
`@@ -235,6 +235,7 @@ const _NumberPicker = forwardRef<NumberPickerRef, NumberPickerProps>(`
`235`	`235`	`aria-label={label}`
`236`	`236`	`ref={pickerRef}`
`237`	`237`	`data-focusable`
	`238`	`+ role="spinbutton"`
`238`	`239`	`{...rest}`
`239`	`240`	`>`
`240`	`241`	`<StyledTimeIconButton`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "latestCommitSHA": "a883158ada835e11be8ad15d5f1e6e4eecf30f01"`
	`2`	`+ "latestCommitSHA": "b902d2225a72447f071e2d74b48ad14c479dc8fa"`
`3`	`3`	`}`