fix(NumberPicker): shall add aria-valuenow for current value when role is spinbutton, or it will read 0

CodingOnDesk · 233mawile-rc · commit 2e4799896ba6 · 2025-03-26T16:55:55.000+08:00
diff --git a/packages/juno-core/src/components/Forms/Picker/TimePicker/NumberPicker.tsx b/packages/juno-core/src/components/Forms/Picker/TimePicker/NumberPicker.tsx
@@ -236,6 +236,7 @@ const _NumberPicker = forwardRef<NumberPickerRef, NumberPickerProps>(
         ref={pickerRef}
         data-focusable
         role="spinbutton"
+        aria-valuenow={innerValue}
         {...rest}
       >
         <StyledTimeIconButton
diff --git a/sync-github.json b/sync-github.json
@@ -1,3 +1,3 @@
 {
-  "latestCommitSHA": "217862f67c0687286a2ffce9b64e4fe7388d7be3"
+  "latestCommitSHA": "ddf7e999046e3a7ba85abdf1501bd50e572a7df8"
 }

Original file line number	Diff line number	Diff line change
`@@ -236,6 +236,7 @@ const _NumberPicker = forwardRef<NumberPickerRef, NumberPickerProps>(`
`236`	`236`	`ref={pickerRef}`
`237`	`237`	`data-focusable`
`238`	`238`	`role="spinbutton"`
	`239`	`+ aria-valuenow={innerValue}`
`239`	`240`	`{...rest}`
`240`	`241`	`>`
`241`	`242`	`<StyledTimeIconButton`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`{`
`2`		`- "latestCommitSHA": "217862f67c0687286a2ffce9b64e4fe7388d7be3"`
	`2`	`+ "latestCommitSHA": "ddf7e999046e3a7ba85abdf1501bd50e572a7df8"`
`3`	`3`	`}`