Updated all uses of DateTime.Now to DateTime.UtcNow

Author: ashneilson

RICADO.Omron/Channels/EthernetChannel.cs

@@ -71,7 +71,7 @@ internal async Task<ProcessRequestResult> ProcessRequestAsync(FINSRequest reques
             int packetsSent = 0;
             int bytesReceived = 0;
             int packetsReceived = 0;
-            DateTime startTimestamp = DateTime.Now;
+            DateTime startTimestamp = DateTime.UtcNow;
 
             while (attempts <= retries)
             {
@@ -126,7 +126,7 @@ internal async Task<ProcessRequestResult> ProcessRequestAsync(FINSRequest reques
                     PacketsSent = packetsSent,
                     BytesReceived = bytesReceived,
                     PacketsReceived = packetsReceived,
-                    Duration = DateTime.Now.Subtract(startTimestamp).TotalMilliseconds,
+                    Duration = DateTime.UtcNow.Subtract(startTimestamp).TotalMilliseconds,
                     Response = FINSResponse.CreateNew(responseMessage, request),
                 };
             }

RICADO.Omron/Channels/EthernetTCPChannel.cs

@@ -216,12 +216,12 @@ private async Task<ReceiveMessageResult> receiveMessageAsync(enTCPCommandCode co
             try
             {
                 List<byte> receivedData = new List<byte>();
-                DateTime startTimestamp = DateTime.Now;
+                DateTime startTimestamp = DateTime.UtcNow;
 
-                while (DateTime.Now.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < TCP_HEADER_LENGTH)
+                while (DateTime.UtcNow.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < TCP_HEADER_LENGTH)
                 {
                     Memory<byte> buffer = new byte[4096];
-                    TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.Now.Subtract(startTimestamp));
+                    TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.UtcNow.Subtract(startTimestamp));
 
                     if (receiveTimeout.TotalMilliseconds >= 50)
                     {
@@ -311,12 +311,12 @@ private async Task<ReceiveMessageResult> receiveMessageAsync(enTCPCommandCode co
 
                 if (receivedData.Count < tcpMessageDataLength)
                 {
-                    startTimestamp = DateTime.Now;
+                    startTimestamp = DateTime.UtcNow;
 
-                    while (DateTime.Now.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < tcpMessageDataLength)
+                    while (DateTime.UtcNow.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < tcpMessageDataLength)
                     {
                         Memory<byte> buffer = new byte[4096];
-                        TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.Now.Subtract(startTimestamp));
+                        TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.UtcNow.Subtract(startTimestamp));
 
                         if (receiveTimeout.TotalMilliseconds >= 50)
                         {

RICADO.Omron/Channels/EthernetUDPChannel.cs

@@ -123,12 +123,12 @@ protected override async Task<ReceiveMessageResult> ReceiveMessageAsync(int time
             try
             {
                 List<byte> receivedData = new List<byte>();
-                DateTime startTimestamp = DateTime.Now;
+                DateTime startTimestamp = DateTime.UtcNow;
 
-                while(DateTime.Now.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < FINSResponse.HEADER_LENGTH + FINSResponse.COMMAND_LENGTH + FINSResponse.RESPONSE_CODE_LENGTH)
+                while(DateTime.UtcNow.Subtract(startTimestamp).TotalMilliseconds < timeout && receivedData.Count < FINSResponse.HEADER_LENGTH + FINSResponse.COMMAND_LENGTH + FINSResponse.RESPONSE_CODE_LENGTH)
                 {
                     Memory<byte> buffer = new byte[4096];
-                    TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.Now.Subtract(startTimestamp));
+                    TimeSpan receiveTimeout = TimeSpan.FromMilliseconds(timeout).Subtract(DateTime.UtcNow.Subtract(startTimestamp));
 
                     if (receiveTimeout.TotalMilliseconds >= 50)
                     {

RICADO.Omron/OmronPLC.cs

@@ -40,10 +40,6 @@ public class OmronPLC : IDisposable
 
         internal EthernetChannel Channel => _channel;
 
-        internal int MaximumReadWordLength => _plcType == enPLCType.CP1 ? 499 : 999;
-
-        internal int MaximumWriteWordLength => _plcType == enPLCType.CP1 ? 496 : 996;
-
         internal bool IsNSeries => _plcType switch
         {
             enPLCType.NJ101 => true,
@@ -113,6 +109,10 @@ public int Retries
 
         public string ControllerVersion => _controllerVersion;
 
+        public int MaximumReadWordLength => _plcType == enPLCType.CP1 ? 499 : 999;
+
+        public int MaximumWriteWordLength => _plcType == enPLCType.CP1 ? 496 : 996;
+
         #endregion