use long syntax for pg_dump command

why: explicit is always better, by removing confusion on uncommon
options

Author: fblackburn1

pganonymize/utils.py

@@ -298,8 +298,8 @@ def create_database_dump(filename, db_args):
     env_vars = ''
     if db_args.get('password'):
         env_vars += 'PGPASSWORD={password}'.format(password=db_args['password'])
-    arguments = '-d {dbname} -U {user} -h {host} -p {port}'.format(**db_args)
-    cmd = '{env_vars}pg_dump -Fc -Z 9 {args} -f {filename}'.format(
+    arguments = '--dbname {dbname} --username {user} --host {host} --port {port}'.format(**db_args)
+    cmd = '{env_vars}pg_dump --format custom --compress 9 {args} --file {filename}'.format(
         env_vars='{} '.format(env_vars) if env_vars else '',
         args=arguments,
         filename=filename

tests/test_cli.py

@@ -56,7 +56,7 @@ class TestCli(object):
              call('UPDATE "auth_user" t SET "first_name" = s."first_name", "last_name" = s."last_name", "email" = s."email" FROM "tmp_auth_user" s WHERE t."id" = s."id"')  # noqa
          ],
          1,
-         [call('PGPASSWORD=my-cool-password pg_dump -Fc -Z 9 -d db -U root -h localhost -p 5432 -f ./dump.sql', shell=True)]  # noqa
+         [call('PGPASSWORD=my-cool-password pg_dump --format custom --compress 9 --dbname db --username root --host localhost --port 5432 --file ./dump.sql', shell=True)]  # noqa
          ],
 
         ['--list-providers --parallel',

tests/test_utils.py

@@ -241,7 +241,7 @@ def test(self, mock_call):
             {'dbname': 'database', 'user': 'foo', 'host': 'localhost', 'port': 5432},
         )
         mock_call.assert_called_once_with(
-            'pg_dump -Fc -Z 9 -d database -U foo -h localhost -p 5432 -f /tmp/dump.gz',
+            'pg_dump --format custom --compress 9 --dbname database --username foo --host localhost --port 5432 --file /tmp/dump.gz',
             shell=True,
         )
 
@@ -252,6 +252,6 @@ def test_with_password(self, mock_call):
             {'dbname': 'database', 'user': 'foo', 'host': 'localhost', 'port': 5432, 'password': 'pass'},
         )
         mock_call.assert_called_once_with(
-            'PGPASSWORD=pass pg_dump -Fc -Z 9 -d database -U foo -h localhost -p 5432 -f /tmp/dump.gz',
+            'PGPASSWORD=pass pg_dump --format custom --compress 9 --dbname database --username foo --host localhost --port 5432 --file /tmp/dump.gz',
             shell=True,
         )