test: confirm PSG support for extreme pitch bend ranges

Author: rhargreaves

tests/test_helpers.h

@@ -9,6 +9,7 @@
 #define MIDI_CHANNEL_1 0
 #define MIDI_CHANNEL_3 2
 #define MIDI_CHANNEL_6 5
+#define MIDI_CHANNEL_7 6
 #define MIDI_CHANNEL_11 10
 
 #define MIDI_VOLUME_MAX 127
@@ -101,8 +102,8 @@
 #define PSG_CH3 2
 #define PSG_NOISE_CH4 3
 
-#define TONE_NTSC_AS4 479
+#define TONE_NTSC_AS3 479
 #define TONE_NTSC_C4 427
 #define TONE_NTSC_CS4 403
 #define TONE_NTSC_DS4 380
-#define TONE_NTSC_A2 1016
+#define TONE_NTSC_A2 1016

tests/unit/main.c

@@ -199,6 +199,7 @@ int main(void)
         midi_test(test_midi_ignores_further_data_entry_messages_after_null_rpn),
         midi_test(test_midi_sets_pitch_bend_sensitivity_with_odd_ordering),
         midi_test(test_midi_logs_invalid_rpn_upon_data_entry),
+        midi_test(test_midi_psg_supports_extreme_pitch_bend_sensitivity),
 
         midi_dac_test(test_midi_dac_plays_note),
         midi_dac_test(test_midi_dac_stops_note),

tests/unit/test_midi_psg.c

@@ -165,7 +165,7 @@ void test_midi_sets_psg_pitch_bend_down(UNUSED void** state)
         expect_psg_attenuation(expectedPsgChan, PSG_ATTENUATION_LOUDEST);
         __real_midi_note_on(chan, MIDI_PITCH_C4, MAX_MIDI_VOLUME);
 
-        expect_psg_tone(expectedPsgChan, TONE_NTSC_AS4);
+        expect_psg_tone(expectedPsgChan, TONE_NTSC_AS3);
         __real_midi_pitch_bend(chan, 0);
     }
 }
@@ -428,3 +428,21 @@ void test_midi_psg_sets_busy_indicators(UNUSED void** state)
     u8 busy = midi_psg_busy();
     assert_int_equal(busy, 0b1010);
 }
+
+void test_midi_psg_supports_extreme_pitch_bend_sensitivity(UNUSED void** state)
+{
+    expect_psg_tone(PSG_CH1, TONE_NTSC_C4);
+    expect_psg_attenuation(PSG_CH1, PSG_ATTENUATION_LOUDEST);
+    __real_midi_note_on(MIDI_CHANNEL_7, MIDI_PITCH_C4, MAX_MIDI_VOLUME);
+
+    __real_midi_cc(MIDI_CHANNEL_7, CC_RPN_MSB, RPN_PITCH_BEND_SENSITIVITY_MSB);
+    __real_midi_cc(MIDI_CHANNEL_7, CC_RPN_LSB, RPN_PITCH_BEND_SENSITIVITY_LSB);
+    __real_midi_cc(MIDI_CHANNEL_7, CC_DATA_ENTRY_MSB, 48);
+    __real_midi_cc(MIDI_CHANNEL_7, CC_DATA_ENTRY_LSB, 0);
+
+    expect_psg_tone(PSG_CH1, 0x1a);
+    __real_midi_pitch_bend(MIDI_CHANNEL_7, MIDI_PITCH_BEND_MAX);
+
+    expect_psg_tone(PSG_CH1, TONE_NTSC_A2);
+    __real_midi_pitch_bend(MIDI_CHANNEL_7, MIDI_PITCH_BEND_MIN);
+}

tests/unit/test_midi_psg.h

@@ -27,3 +27,4 @@ void test_midi_pitch_shift_handles_upper_limit_psg_envelope(UNUSED void** state)
 void test_midi_pitch_shift_handles_lower_limit_psg_envelope(UNUSED void** state);
 void test_midi_loads_psg_envelope(UNUSED void** state);
 void test_midi_psg_sets_busy_indicators(UNUSED void** state);
+void test_midi_psg_supports_extreme_pitch_bend_sensitivity(UNUSED void** state);