Implement a better wireless network support

[NotMephisto]

Logs:

(gjs:1280734): Gjs-CRITICAL **: 01:55:45.469: JS ERROR: TypeError: (intermediate value).__80211ApFlags is undefined
PageNetwork/<.children<.children</</<.endWidget<.icon<@file:///run/user/1000/ags.js:3703:61
as/bind2.transformFn@file:///run/user/1000/ags.js:331:34
get@file:///run/user/1000/ags.js:340:21
construct@file:///run/user/1000/ags.js:668:35
Widget3@file:///run/user/1000/ags.js:784:16
Icon@file:///run/user/1000/ags.js:1085:5
PageNetwork/<.children<.children</<@file:///run/user/1000/ags.js:3702:24
PageNetwork/<.children<.children<@file:///run/user/1000/ags.js:3698:42
as/bind2.transformFn@file:///run/user/1000/ags.js:331:34
as/bind2.transformFn@file:///run/user/1000/ags.js:331:40
get@file:///run/user/1000/ags.js:340:21
construct@file:///run/user/1000/ags.js:642:40
Widget3@file:///run/user/1000/ags.js:784:16
Box@file:///run/user/1000/ags.js:1020:5
PageNetwork@file:///run/user/1000/ags.js:3687:5
onClickMore@file:///run/user/1000/ags.js:3852:49
onClick@file:///run/user/1000/ags.js:3159:50
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34


(gjs:1280734): GLib-GObject-CRITICAL **: 01:55:46.067: ../gobject/gsignal.c:2684: instance '0x56037e426260' has no handler with id '766'

[retrozinndev]

Oh, sorry for that. I'll check the official libnm documentation to see a possible fix.

I thought the NM.__80211ApFlags enum existed because it actually was in the ts-for-gir types.

[retrozinndev]

Found it. For some reason, ts-for-gir generated the NM.80211ApFlags enum incorrectly, adding __ as a prefix. I'll push a fix for this right now.

[retrozinndev]

Could you please try again with the new commit 9ed3ac3 ?

[NotMephisto]

When trying to connect to the network (after fix):

(gjs:1323431): Gjs-CRITICAL **: 11:55:14.096: JS ERROR: Error: Provided input cannot be converted to ArrayBufferView or ArrayBuffer decode@resource:///org/gnome/gjs/modules/esm/_encoding/encoding.js:112:19 getDecoded@file:///run/user/1000/ags.js:2297:18 onClick@file:///run/user/1000/ags.js:3715:86 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34

Also got this when clicking on available network:

(gjs:1325177): Gjs-CRITICAL **: 11:58:28.476: JS ERROR: Error: You cannot construct new instances of 'GObject_Interface' onClick@file:///run/user/1000/ags.js:3714:34 _init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:263:34

[retrozinndev]

You seem to have edited the original code, could you please send the modified version here?

[NotMephisto]

I haven't managed to make my changes in ../../pages/Netwotk.ts yet.

P.s.: I fixed the first error, but the second one doesn't give me a widget to enter my password and connect again.

[retrozinndev]

P.s.: I fixed the first error, but the second one doesn't give me a widget to enter my password and connect again.

Hmm, strange. I'll take a look to see what's causing this issue.

Also, sorry for my delay to answer.

[retrozinndev]

How did you fix the first error?

I'm very sorry for the trouble, I made this as a provisory way to connect to wireless networks for the people that use Wi-Fi, because I really don't have a Wi-Fi card, so I can't test this much.

[NotMephisto]

How did you fix the first error?

I just... didn't make the correct changes to utils.ts :D

I'm very sorry for the trouble, I made this as a provisory way to connect to wireless networks for the people that use Wi-Fi, because I really don't have a Wi-Fi card, so I can't test this much.

It's okay! I'll help you with the tests, and by the way, what's the best way to get NM.Connection and NM.ActiveConnection for each item from dev? Required for the deactivate_connection_async() and activate_connection_async() functions

[retrozinndev]

I just... didn't make the correct changes to utils.ts :D

Oh! 😁

It's okay! I'll help you with the tests [...]

Thanks for helping me!! I appreciate that 🤩

[...] and by the way, what's the best way to get NM.Connection and NM.ActiveConnection for each item from dev? Required for the deactivate_connection_async() and activate_connection_async() functions

Sorry if I'm mistaken, but do you want to get the current NMActiveConnection + available connections for each NMDevice of NMClient? If that's it, you can do so with:

import AstalNetwork from "gi://AstalNetwork";

// Loop through NMClient's devices(NMDevice)
for(const dev of AstalNetwork.get_default().get_client().get_devices()) {
    dev.get_available_connections(); // Returns an array of NMConnection(specifically NMRemoteConnection) available for dev(NMDevice)
    dev.get_active_connection(); // Returns current connection(in-use) of the dev(NMDevice)
}

Also, I saw in your last pull request that you have module import errors, I guess you haven't built the GObject Introspection Repository(GIR) types for TypeScript.
You can do that with ags types inside the shell project directory(where you edit the code and test). This will give you code completion for all the libraries in the project.

[NotMephisto]

Sorry if I'm mistaken, but do you want to get the current NMActiveConnection + available connections for each NMDevice of NMClient?

Yes, I need to get the connection parameters. For example, I want to disable wifi specifically. Do I need to use get_active_connections() or get_connection_type() and process it there by connection type? And the problem is that the activate_connection_async() and deactivate_connection_async() functions require different connection types, which complicates my understanding of getting them.

Also, I saw in your last pull request that you have module import errors, I guess you haven't built the GObject Introspection Repository(GIR) types for TypeScript.
You can do that with ags types inside the shell project directory(where you edit the code and test). This will give you code completion for all the libraries in the project.

Thanks, I had just fixed that!

[retrozinndev]

Yes, I need to get the connection parameters. For example, I want to disable wifi specifically. Do I need to use get_active_connections() or get_connection_type() and process it there by connection type? And the problem is that the activate_connection_async() and deactivate_connection_async() functions require different connection parameters, which complicates my understanding of getting them.

You don't actually need to deactivate all connections from a NMDevice(wifi adapter) to disable it, instead, you can just disable wireless devices(these are generally wifi adapters) by using:

import AstalNetwork from "gi://AstalNetwork";

AstalNetwork.get_default().get_client().wireless_set_enabled(false); // or `true` if you want to enable them

Thanks, I had just fixed that!

Nice! 😁