A few minor tweaks

Author: retep998

src/lib.rs

@@ -11,7 +11,7 @@
 #![no_std]
 //Uncomment as needed or once minimum Rust version is bumped to 1.18
 //#![cfg_attr(feature = "cargo-clippy", warn(clippy::pedantic))]
-//#![cfg_attr(feature = "cargo-clippy", allow(clippy::absurd_extreme_comparisons, clippy::cast_lossless, clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_precision_loss, clippy::cast_ptr_alignment, clippy::cast_sign_loss, clippy::const_static_lifetime, clippy::doc_markdown, clippy::empty_enum, clippy::erasing_op, clippy::excessive_precision, clippy::expl_impl_clone_on_copy, clippy::identity_op, clippy::if_not_else, clippy::many_single_char_names, clippy::module_inception, clippy::cast_possible_truncation, clippy::too_many_arguments, clippy::transmute_int_to_float, clippy::trivially_copy_pass_by_ref, clippy::unreadable_literal, clippy::unseparated_literal_suffix, clippy::used_underscore_binding))]
+//#![cfg_attr(feature = "cargo-clippy", allow(clippy::absurd_extreme_comparisons, clippy::cast_lossless, clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_precision_loss, clippy::cast_ptr_alignment, clippy::cast_sign_loss, clippy::doc_markdown, clippy::empty_enum, clippy::erasing_op, clippy::excessive_precision, clippy::expl_impl_clone_on_copy, clippy::identity_op, clippy::if_not_else, clippy::many_single_char_names, clippy::module_inception, clippy::cast_possible_truncation, clippy::too_many_arguments, clippy::transmute_int_to_float, clippy::trivially_copy_pass_by_ref, clippy::unreadable_literal, clippy::unseparated_literal_suffix, clippy::used_underscore_binding, clippy::redundant_static_lifetimes, clippy::missing_safety_doc))]
 
 #[cfg(feature = "std")]
 extern crate std;

src/shared/ifdef.rs

@@ -105,16 +105,16 @@ ENUM!{enum NET_IF_ACCESS_TYPE {
 }}
 pub type PNET_IF_ACCESS_TYPE = *mut NET_IF_ACCESS_TYPE;
 ENUM!{enum NET_IF_DIRECTION_TYPE {
-    NET_IF_DIRECTION_SENDRECEIVE = 0,
-    NET_IF_DIRECTION_SENDONLY = 1,
-    NET_IF_DIRECTION_RECEIVEONLY = 2,
-    NET_IF_DIRECTION_MAXIMUM = 3,
+    NET_IF_DIRECTION_SENDRECEIVE,
+    NET_IF_DIRECTION_SENDONLY,
+    NET_IF_DIRECTION_RECEIVEONLY,
+    NET_IF_DIRECTION_MAXIMUM,
 }}
 pub type PNET_IF_DIRECTION_TYPE = *mut NET_IF_DIRECTION_TYPE;
 ENUM!{enum NET_IF_MEDIA_CONNECT_STATE {
-    MediaConnectStateUnknown = 0,
-    MediaConnectStateConnected = 1,
-    MediaConnectStateDisconnected = 2,
+    MediaConnectStateUnknown,
+    MediaConnectStateConnected,
+    MediaConnectStateDisconnected,
 }}
 pub type PNET_IF_MEDIA_CONNECT_STATE = *mut NET_IF_MEDIA_CONNECT_STATE;
 ENUM!{enum NET_IF_MEDIA_DUPLEX_STATE {

src/shared/netioapi.rs

@@ -29,10 +29,10 @@ const ANY_SIZE: usize = 1;
 pub type NETIO_STATUS = DWORD;
 pub type NETIOAPI_API = NETIO_STATUS;
 ENUM!{enum MIB_NOTIFICATION_TYPE {
-    MibParameterNotification = 0,
-    MibAddInstance = 1,
-    MibDeleteInstance = 2,
-    MibInitialNotification = 3,
+    MibParameterNotification,
+    MibAddInstance,
+    MibDeleteInstance,
+    MibInitialNotification,
 }}
 pub type PMIB_NOTIFICATION_TYPE = *mut MIB_NOTIFICATION_TYPE;
 STRUCT!{struct MIB_IF_ROW2_InterfaceAndOperStatusFlags {

src/shared/nldef.rs

@@ -8,10 +8,10 @@ use shared::minwindef::ULONG;
 use shared::ntdef::BOOLEAN;
 ENUM!{enum NL_PREFIX_ORIGIN {
     IpPrefixOriginOther = 0,
-    IpPrefixOriginManual = 1,
-    IpPrefixOriginWellKnown = 2,
-    IpPrefixOriginDhcp = 3,
-    IpPrefixOriginRouterAdvertisement = 4,
+    IpPrefixOriginManual,
+    IpPrefixOriginWellKnown,
+    IpPrefixOriginDhcp,
+    IpPrefixOriginRouterAdvertisement,
     IpPrefixOriginUnchanged = 1 << 4,
 }}
 pub const NlpoOther: NL_PREFIX_ORIGIN = IpPrefixOriginOther;
@@ -35,17 +35,17 @@ ENUM!{enum NL_SUFFIX_ORIGIN {
     IpSuffixOriginUnchanged = 1 << 4,
 }}
 ENUM!{enum NL_DAD_STATE {
+    NldsInvalid,
+    NldsTentative,
+    NldsDuplicate,
+    NldsDeprecated,
+    NldsPreferred,
     IpDadStateInvalid = 0,
-    IpDadStateTentative = 1,
-    IpDadStateDuplicate = 2,
-    IpDadStateDeprecated = 3,
-    IpDadStatePreferred = 4,
+    IpDadStateTentative,
+    IpDadStateDuplicate,
+    IpDadStateDeprecated,
+    IpDadStatePreferred,
 }}
-pub const NldsInvalid: NL_DAD_STATE = IpDadStateInvalid;
-pub const NldsTentative: NL_DAD_STATE = IpDadStateTentative;
-pub const NldsDuplicate: NL_DAD_STATE = IpDadStateDuplicate;
-pub const NldsDeprecated: NL_DAD_STATE = IpDadStateDeprecated;
-pub const NldsPreferred: NL_DAD_STATE = IpDadStatePreferred;
 pub const NL_MAX_METRIC_COMPONENT: ULONG = (1u32 << 31) - 1;
 ENUM!{enum NL_ROUTE_PROTOCOL {
     RouteProtocolOther = 1,

src/shared/ntddndis.rs

@@ -59,7 +59,7 @@ ENUM!{enum NDIS_PHYSICAL_MEDIUM {
     NdisPhysicalMediumWiredWAN = 17,
     NdisPhysicalMediumWiredCoWan = 18,
     NdisPhysicalMediumOther = 19,
-    NdisPhysicalMediumMax = 20, // Not a real physical type, defined as an upper-bound
+    NdisPhysicalMediumMax = 20,
 }}
 pub type PNDIS_PHYSICAL_MEDIUM = *mut NDIS_PHYSICAL_MEDIUM;
 //2691

src/um/iptypes.rs

@@ -3,9 +3,6 @@
 // <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your option.
 // All files in the project carrying such notice may not be copied, modified, or distributed
 // except according to those terms.
-// #include <winapifamily.h>
-// #include <ifdef.h>
-// #include <nldef.h>
 use shared::basetsd::{UINT8, ULONG64};
 use shared::guiddef::GUID;
 use shared::ifdef::{
@@ -292,7 +289,6 @@ BITFIELD!{IP_ADAPTER_ADDRESSES_LH Flags: ULONG [
     Ipv4Enabled set_Ipv4Enabled[7..8],
     Ipv6Enabled set_Ipv6Enabled[8..9],
     Ipv6ManagedAddressConfigurationSupported set_Ipv6ManagedAddressConfigurationSupported[9..10],
-    Reserved set_Reserved[10..32],
 ]}
 pub type PIP_ADAPTER_ADDRESSES_LH = *mut IP_ADAPTER_ADDRESSES_LH;
 STRUCT!{struct IP_ADAPTER_ADDRESSES_XP_u_s {