-
Notifications
You must be signed in to change notification settings - Fork 494
Open
Labels
enhancementNew feature or requestNew feature or request😤 annoyingSomething in the UI / SDK is annoying to useSomething in the UI / SDK is annoying to use
Description
We currently fail to parse URLs like rerun+http://13.31.13.31/rerun/proxy
. We probably should be more lenient and allow this, because we can always tack more pathname segments at the end.
After parsing, we should keep the original pathname around minus the endpoint, e.g. the above will become http://13.31.13.31/rerun
. An example gRPC client request to that URL is POST http://13.31.13.31/rerun/rerun.v1alpha1.sdk_comms.MessageProxyService/ReadMessages
. As long as /rerun/*
is proxied to the gRPC server with the path rewritten to /rerun.v1alpha1.sdk_comms.MessageProxyService/ReadMessages
, that should be enough.
stefanwagnerdev
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request😤 annoyingSomething in the UI / SDK is annoying to useSomething in the UI / SDK is annoying to use