Embedding of *.feature files as resources inflates the binary files significantly

[MarkKharitonov]

Reqnroll Version

Latest

Which test runner are you using?

MSTest

Test Runner Version Number

Latest

.NET Implementation

.NET Framework 4.6.2 or later

Test Execution Method

Visual Studio Test Explorer

Content of reqnroll.json configuration file

N/A

Issue Description

One example we have is of a binary 147MB in size of which 81MB are the embedded *.feature files.
Looking at the build code, this is unconditional logic.

I wonder if it is really necessary and if the *.feature files are needed, can they just be copied to the bin directory without embedding them?

Steps to Reproduce

Just build any project with *.feature files. They are compiled as EmbeddedResource and end up in the binary,

Link to Repro Project

No response

[Code-Grump]

I suppose this begs the question: is there something important or impactful about having a large binary versus a medium binary with satellite files?

[clrudolphi]

Huh, I wasn't aware Reqnroll was doing this. Is/was there a feature in play that needed the text of the feature at runtime?

[304NotModified]

Huh, I wasn't aware Reqnroll was doing this. Is/was there a feature in play that needed the text of the feature at runtime?

Same for me, I'm also curious. I don't think it should be embedded.

[gasparnagy]

I don't remember why this was needed, but I'm pretty sure this is not used in general anymore. So I think we can go along and implement this in an "opt-in" way even (so that they are not embedded by default).

[304NotModified]

If it isn't needed, then V3 would be nice and then IMO a out-out is also OK - but that's my opinion :)

[clrudolphi]

How should this option be exposed? As an environment variable? A Reqnroll.json configuration setting?

[MarkKharitonov]

Here is the PR - #665
I would like to update the documentation, but I am not sure which document. Please, advise.

[clrudolphi]

I would like to update the documentation

The documentation is lacking any detail on the workings of the build targets and how to customize them. Perhaps we should have them documented, but at present we do not.

Please give the core team a few weeks to think this through. The .git blame for that section of the targets file indicates this behavior goes way back (about 5-6 years). The lead for Reqnroll (Gaspar) would be the only team member who has been around that long to provide historical context as to why that behavior is present. Unfortunately, he is on holiday until later this month.

We may uncover that these files were embedded for an intent that never came to pass and thus we can eliminate it completely. Or it may be necessary for a reason we (newer team members) don't understand.

Thank you for your patience.