Public API in the plugins #495
304NotModified
started this conversation in
General
Replies: 1 comment
-
Yes, we should clarify the rules. But FYI: changes in plugins, like in Autofac are not always breaking according to https://docs.reqnroll.net/latest/installation/compatibility.html#versioning-policy-of-reqnroll-plugins |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I realized that I made a breaking change in #479, as there is a lot of code that
public
while that's isn't necessary. It makes it very hard to fix bugs or make improvements without breaking code.E.g. in ServiceCollectionFinder.cs has a public constructor (ctor), so you could never change the dependencies 🫨
Possible options:
internal
/private
. Maybe change the minor version number for this change (2.3.x -> 2.4.x). This means, also merge Remove deadcode in AutoFac plugin #480Beta Was this translation helpful? Give feedback.
All reactions