Moq to NSubstitute

[304NotModified]

Are there any plans to replace Moq - because of this: devlooped/moq#1374?

I propose NSubstitute. Another lib is also an option, but IMO NSubstitute is the best replacement.

I've done many migrations of Moq with NSubstitute, so I could do that. But it's a bit tricky with open PRs as it touches all tests

[gasparnagy]

I think we should and I appreciate your willingness to help. But let's do a proof of concept first: Could you just pick one test class (practically one that uses Moq in a bit more tricky fashion) and replace that with NSubstitute? So that we can see the impact. If that is successful, we can broaden the scope.

[304NotModified]

The POC is here! --> #496

This took me a few minutes with converter scripts and some changing by hand

It's hard to find the tricky parts. Another option is to try to change all of the test code base and let's see where we has difficulties.

[304NotModified]

This took me ~1 hour, and there are some difficult parts, but not much. See
#497

[304NotModified]

So there is a POC, there are some hard parts but not that many #497

I propose the following:

• First merge the large PRs:
  • Feature/Cucumber Messages #233 191 changed files
  • Add Roslyn source generator #200 133 changed files - update note sure, it's not really active now
• simply the hard parts before migration
• replace Moq with NSubstitute, on project per PR - to keep the PR reviewable
• start with project Reqnroll.PluginTests

Please your opinion :)

[304NotModified]

I see also these repo's has Moq, so I could start maybe with those

• https://github.com/reqnroll/Reqnroll.VisualStudio
• https://github.com/reqnroll/Reqnroll.Actions

[gasparnagy]

Good idea. The Reqnroll.Actions is mainly legacy/compatibility code, so don't die for that, but the VS extension is a good candidate.