Skip to content

Support datetime for since and until repo-config.csv #2373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeng03 opened this issue Apr 2, 2025 · 1 comment
Open

Support datetime for since and until repo-config.csv #2373

joeng03 opened this issue Apr 2, 2025 · 1 comment

Comments

@joeng03
Copy link
Contributor

joeng03 commented Apr 2, 2025

Currently, we have #2369 to support datetime for since and until through CLI. Due to urgency for the CLI functionality to be merged, let's move support for datetime in repo-config.csv as another separate issue, as it may contain significant test and system test changes, as well as User Guide updates.

@joeng03 joeng03 changed the title Support datetime for since and until in repo-config.csv Support datetime for since and until: Further enhancements Apr 3, 2025
@joeng03 joeng03 changed the title Support datetime for since and until: Further enhancements Support datetime for since and until repo-config.csv Apr 3, 2025
@CYX22222003
Copy link
Contributor

CYX22222003 commented Apr 8, 2025

If possible, describe the solution

In terms of the function code the only thing should be changing is the one in the RepoConfigCsvParser.java. Currently, the since date and until date are taken in the format of dd/MM/yyyy and then hardcoded into valid LocalDatetime object by manually adding the default since date start time and default until date end time.

A way to solve this issue is to relax the constraint on the format of date time input in the CSV. We can support both dd/MM/yyyy and dd/MM/yyyyTHH:mm at the same time. Only hardcoding and overwriting the dates is specific time is not provided.

It will be suitable for first-comer to work on this so that they can get a rough idea of how the arguments are parsed and the repos are analyzed from the experience of implementing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants