Quick fix to prevent panic on nil collector result (#1508)

nvanthao · web-flow · commit 6f839b389de6 · 2024-03-18T16:42:52.000+11:00
* quick fix to prevent panic on nil collector result
* do not save pod details on error
diff --git a/pkg/collect/run_pod.go b/pkg/collect/run_pod.go
@@ -72,6 +72,9 @@ func (c *CollectRunPod) Collect(progressChan chan<- interface{}) (result Collect
 	}
 
 	defer func() {
+		if err != nil {
+			return
+		}
 		result, err = savePodDetails(ctx, client, result, c.BundlePath, c.ClientConfig, pod, c.Collector)
 		if err != nil {
 			klog.Errorf("failed to save pod details: %v", err)

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,9 @@ func (c *CollectRunPod) Collect(progressChan chan<- interface{}) (result Collect`
`72`	`72`	`}`
`73`	`73`
`74`	`74`	`defer func() {`
	`75`	`+ if err != nil {`
	`76`	`+ return`
	`77`	`+ }`
`75`	`78`	`result, err = savePodDetails(ctx, client, result, c.BundlePath, c.ClientConfig, pod, c.Collector)`
`76`	`79`	`if err != nil {`
`77`	`80`	`klog.Errorf("failed to save pod details: %v", err)`