Skip to content

Commit ebe2d70

Browse files
committed
f
1 parent 0f14e2b commit ebe2d70

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

api/internal/managers/app/config/config.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,14 +167,15 @@ func isItemEnabled(when multitype.QuotedBool) bool {
167167
return when != "false"
168168
}
169169

170+
// isRequiredItem checks if an item is required based on whether Required is true and the item is
171+
// enabled and not hidden
170172
func isRequiredItem(item kotsv1beta1.ConfigItem) bool {
171173
if !item.Required {
172174
return false
173175
}
174176
if !isItemEnabled(item.When) {
175177
return false
176178
}
177-
// TODO: should an item really not be required if it's hidden?
178179
if item.Hidden {
179180
return false
180181
}

0 commit comments

Comments
 (0)