prompt if manager will use self-signed cert (#2313)

* prompt if manager will use self-signed cert

* fix test race

---------

Co-authored-by: Ethan Mosbaugh <ethan@replicated.com>

Author: ajp-io

api/integration/install_test.go

@@ -209,18 +209,15 @@ func TestConfigureInstallation(t *testing.T) {
 				require.NoError(t, err)
 
 				// Verify that the status was properly set
-				assert.Equal(t, types.StateRunning, status.State)
-				assert.Equal(t, "Configuring installation", status.Description)
-			}
-
-			if !tc.expectedError {
 				// The status is set to succeeded in a goroutine, so we need to wait for it
 				assert.Eventually(t, func() bool {
 					status, err := installController.GetInstallationStatus(t.Context())
 					require.NoError(t, err)
-					return status.State == types.StateSucceeded
-				}, 1*time.Second, 100*time.Millisecond)
+					return status.State == types.StateSucceeded && status.Description == "Installation configured"
+				}, 1*time.Second, 100*time.Millisecond, "status should eventually be succeeded")
+			}
 
+			if !tc.expectedError {
 				// Verify that the config is in the store
 				storedConfig, err := installController.GetInstallationConfig(t.Context())
 				require.NoError(t, err)

cmd/installer/cli/install.go

@@ -337,6 +337,23 @@ func runManagerExperienceInstall(ctx context.Context, flags InstallCmdFlags, rc
 		return fmt.Errorf("unable to list all valid IP addresses: %w", err)
 	}
 
+	if flags.tlsCertFile == "" || flags.tlsKeyFile == "" {
+		logrus.Warn("\nNo certificate files provided. A self-signed certificate will be used, and your browser will show a security warning.")
+		logrus.Info("To use your own certificate, provide both --tls-key and --tls-cert flags.")
+
+		if !flags.assumeYes {
+			logrus.Info("") // newline so the prompt is separated from the warning
+			confirmed, err := prompts.New().Confirm("Do you want to continue with a self-signed certificate?", false)
+			if err != nil {
+				return fmt.Errorf("failed to get confirmation: %w", err)
+			}
+			if !confirmed {
+				logrus.Infof("\nInstallation cancelled. Please run the command again with the --tls-key and --tls-cert flags.\n")
+				return nil
+			}
+		}
+	}
+
 	if flags.tlsCertFile != "" && flags.tlsKeyFile != "" {
 		cert, err := tls.LoadX509KeyPair(flags.tlsCertFile, flags.tlsKeyFile)
 		if err != nil {