chore(test): actually wait for the os exit signal function to be called before asserting (#2303)

* chore(test): actually wait for the os exit signal function to be called before asserting

* chore: some small reorg

Author: JGAntunes

cmd/installer/cli/signal_test.go

@@ -31,7 +31,6 @@ func Test_signalHandler_Signal(t *testing.T) {
 		if sig != nil {
 			cleanupSignal = sig
 		}
-		wg.Done()
 	}
 
 	// Save original os.Exit and restore after test
@@ -41,8 +40,8 @@ func Test_signalHandler_Signal(t *testing.T) {
 	exitCode := int32(0)
 	osExit = func(code int) {
 		atomic.StoreInt32(&exitCode, int32(code))
-		// Instead of exiting, just cancel the context
-		cancel()
+		// Resume the waitgroup to allow the test to complete
+		wg.Done()
 	}
 
 	// Set up the signal handler
@@ -76,6 +75,8 @@ func Test_signalHandler_Signal(t *testing.T) {
 
 	// Verify cleanup was called with the expected error
 	assert.True(t, cleanupCalled, "Cleanup function should have been called")
+	// Check that the context was cancelled
+	assert.Equal(t, context.Canceled, ctx.Err())
 	assert.Equal(t, syscall.SIGINT, cleanupSignal, "Cleanup should be called with SIGINT")
 	assert.Equal(t, int32(1), atomic.LoadInt32(&exitCode), "Exit code should be 1")
 }